]> granicus.if.org Git - graphviz/commitdiff
smyrna attr_list_add: fix unchecked allocation failure
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Fri, 2 Sep 2022 01:30:01 +0000 (18:30 -0700)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Fri, 2 Sep 2022 01:30:01 +0000 (18:30 -0700)
cmd/smyrna/gui/frmobjectui.c

index c90126402536711aa0161a0872890e625f5f8696..3299b52bb2f689b8f361c1c2089eb5ca36f30187 100644 (file)
@@ -17,7 +17,6 @@
 #include <gdk/gdkkeysyms.h>
 #include <gdk/gdk.h>
 #include "viewport.h"
-#include <common/memory.h>
 #include "frmobjectui.h"
 #include <assert.h>
 #include <ast/sfstr.h>
@@ -189,9 +188,10 @@ static void attr_list_add(attr_list *l, attr_t *a) {
        return;
     l->attr_count++;
     if (l->attr_count == l->capacity) {
+       l->attributes = gv_recalloc(l->attributes, l->capacity,
+                                   l->capacity + EXPAND_CAPACITY_VALUE,
+                                   sizeof(attr_t *));
        l->capacity = l->capacity + EXPAND_CAPACITY_VALUE;
-       l->attributes =
-           realloc(l->attributes, l->capacity * sizeof(attr_t *));
     }
     l->attributes[l->attr_count - 1] = a;
     if (l->attr_count > 1)