removed ->is_ref check, doesn't make sense and causes bugs

diff --git a/ext/com/TODO b/ext/com/TODO
index 3251b5da77d7b261f98ad85cdd643a1a978efd23..038df72a6420c557eff1e909397c5c6a4a9ca916 100644 (file)
--- a/ext/com/TODO
+++ b/ext/com/TODO
@@ -1,5 +1,5 @@
 1) Multi-dimenstional array support
-2) IErrorInfo
+-- done 2) IErrorInfo
 3) WithEvents
 4) Documentation (internal and user) and howtos
 5) IEnumVariant::All() which would be like IEnumVariant::Next(IDispatch::Count)
@@ -8,9 +8,17 @@
 8) Test suite (Needs test component)
 9) reduce the need for VARIANT()
 10) lets try if we are able to call non IDispatch - only Typelib components
-11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
+-- done 11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
+12) VARIANT->value as lvalue
 
 
-these seem to be done:
+ad 6.) check vbsample.php (new VARIANT(*, *|VT_BYREF)) GPs
+ad 4.) faq (i've collected a few questions from various lists)
 
-2) 6) 11)
+to be discussed:
+
+- dcom inporc issue
+- mts support (getcontext)
+- adsi support (ads* functions)
+- winapi interface
+- try serialisation support (if component implements IPersist)

diff --git a/ext/com/conversion.c b/ext/com/conversion.c
index 524888a37d06e47ef54611fbe308e7348a5b3d42..18ce7f17b81c32b48d83775281d14ff9d71969f7 100644 (file)
--- a/ext/com/conversion.c
+++ b/ext/com/conversion.c
@@ -86,7 +86,7 @@ PHPAPI void php_pval_to_variant(pval *pval_arg, VARIANT *var_arg, int codepage T
        }
 
        if (pval_arg->is_ref) { /* deprecated, implemented for downwards compatiblity */
-               type |= VT_BYREF;
+//             type |= VT_BYREF;
        }
 
        pval_to_variant_ex(pval_arg, var_arg, type, codepage TSRMLS_CC);

diff --git a/ext/rpc/com/TODO b/ext/rpc/com/TODO
index 3251b5da77d7b261f98ad85cdd643a1a978efd23..038df72a6420c557eff1e909397c5c6a4a9ca916 100644 (file)
--- a/ext/rpc/com/TODO
+++ b/ext/rpc/com/TODO
@@ -1,5 +1,5 @@
 1) Multi-dimenstional array support
-2) IErrorInfo
+-- done 2) IErrorInfo
 3) WithEvents
 4) Documentation (internal and user) and howtos
 5) IEnumVariant::All() which would be like IEnumVariant::Next(IDispatch::Count)
@@ -8,9 +8,17 @@
 8) Test suite (Needs test component)
 9) reduce the need for VARIANT()
 10) lets try if we are able to call non IDispatch - only Typelib components
-11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
+-- done 11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
+12) VARIANT->value as lvalue
 
 
-these seem to be done:
+ad 6.) check vbsample.php (new VARIANT(*, *|VT_BYREF)) GPs
+ad 4.) faq (i've collected a few questions from various lists)
 
-2) 6) 11)
+to be discussed:
+
+- dcom inporc issue
+- mts support (getcontext)
+- adsi support (ads* functions)
+- winapi interface
+- try serialisation support (if component implements IPersist)

diff --git a/ext/rpc/com/conversion.c b/ext/rpc/com/conversion.c
index 524888a37d06e47ef54611fbe308e7348a5b3d42..18ce7f17b81c32b48d83775281d14ff9d71969f7 100644 (file)
--- a/ext/rpc/com/conversion.c
+++ b/ext/rpc/com/conversion.c
@@ -86,7 +86,7 @@ PHPAPI void php_pval_to_variant(pval *pval_arg, VARIANT *var_arg, int codepage T
        }
 
        if (pval_arg->is_ref) { /* deprecated, implemented for downwards compatiblity */
-               type |= VT_BYREF;
+//             type |= VT_BYREF;
        }
 
        pval_to_variant_ex(pval_arg, var_arg, type, codepage TSRMLS_CC);