]> granicus.if.org Git - python/commitdiff
Issue #18339: use with self.assertRaises() to make test case more readable
authorChristian Heimes <christian@cheimes.de>
Mon, 1 Jul 2013 21:00:13 +0000 (23:00 +0200)
committerChristian Heimes <christian@cheimes.de>
Mon, 1 Jul 2013 21:00:13 +0000 (23:00 +0200)
Lib/test/test_pickle.py

index e96fe523df7547b68da083d8b4c8c13027b91773..fbe96ac2a81827d5852d63c220be17723f85e7b1 100644 (file)
@@ -117,9 +117,11 @@ if has_c_implementation:
 
         def test_issue18339(self):
             unpickler = self.unpickler_class(io.BytesIO())
-            self.assertRaises(TypeError, setattr, unpickler, "memo", object)
+            with self.assertRaises(TypeError):
+                unpickler.memo = object
             # used to cause a segfault
-            self.assertRaises(ValueError, setattr, unpickler, "memo", {-1: None})
+            with self.assertRaises(ValueError):
+                unpickler.memo = {-1: None}
             unpickler.memo = {1: None}
 
     class CDispatchTableTests(AbstractDispatchTableTests):