]> granicus.if.org Git - python/commitdiff
Fix more ResourceWarnings in test_packaging moving the join() and server_close()...
authorEzio Melotti <ezio.melotti@gmail.com>
Fri, 20 May 2011 16:35:58 +0000 (19:35 +0300)
committerEzio Melotti <ezio.melotti@gmail.com>
Fri, 20 May 2011 16:35:58 +0000 (19:35 +0300)
Lib/packaging/tests/pypi_server.py

index 1e4b0120d9cc5f61e47aa5c6e6f1cb261da82eba..d22f5c3ab7818b769eda4084d4f4f59154403a51 100644 (file)
@@ -78,12 +78,7 @@ class PyPIServerTestCase(unittest.TestCase):
         super(PyPIServerTestCase, self).setUp()
         self.pypi = PyPIServer()
         self.pypi.start()
-
-    def tearDown(self):
-        super(PyPIServerTestCase, self).tearDown()
-        self.pypi.stop()
-        self.pypi.join()
-        self.pypi.server.server_close()
+        self.addCleanup(self.pypi.stop)
 
 
 class PyPIServer(threading.Thread):
@@ -154,6 +149,8 @@ class PyPIServer(threading.Thread):
     def stop(self):
         """self shutdown is not supported for python < 2.6"""
         self._run = False
+        self.join()
+        self.server.server_close()
 
     def get_next_response(self):
         return (self.default_response_status,