]> granicus.if.org Git - python/commitdiff
Issue #8407: test_signal doesn't check signal delivery order
authorVictor Stinner <victor.stinner@haypocalc.com>
Tue, 31 May 2011 20:31:09 +0000 (22:31 +0200)
committerVictor Stinner <victor.stinner@haypocalc.com>
Tue, 31 May 2011 20:31:09 +0000 (22:31 +0200)
Tthe signal delivery order is not portable or reliable.

Lib/test/test_signal.py

index 4bf2d2dedfead8f5f4b040520244f652fa1ff5bf..063139061a05e95b074dbffe0e79bcaa0bd61216 100644 (file)
@@ -229,12 +229,13 @@ class WakeupSignalTests(unittest.TestCase):
     def handler(self, signum, frame):
         pass
 
-    def check_signum(self, *signals, **kw):
+    def check_signum(self, *signals):
         data = os.read(self.read, len(signals)+1)
         raised = struct.unpack('%uB' % len(data), data)
-        if kw.get('unordered', False):
-            raised = set(raised)
-            signals = set(signals)
+        # We don't care of the signal delivery order (it's not portable or
+        # reliable)
+        raised = set(raised)
+        signals = set(signals)
         self.assertEqual(raised, signals)
 
     def test_wakeup_fd_early(self):
@@ -291,7 +292,7 @@ class WakeupSignalTests(unittest.TestCase):
         # Unblocking the 2 signals calls the C signal handler twice
         signal.pthread_sigmask(signal.SIG_UNBLOCK, (signum1, signum2))
 
-        self.check_signum(signum1, signum2, unordered=True)
+        self.check_signum(signum1, signum2)
 
     def setUp(self):
         import fcntl