add error check and fix leak

diff --git a/ext/standard/proc_open.c b/ext/standard/proc_open.c
index e443ec64a65809a307577fa87c80c881e563aeb0..95803c9bbd4ac41afbf6788003f1fb9e6997141a 100644 (file)
--- a/ext/standard/proc_open.c
+++ b/ext/standard/proc_open.c
@@ -753,9 +753,14 @@ PHP_FUNCTION(proc_open)
 
                len = (sizeof(COMSPEC_NT) + sizeof(" /c ") + tmp_len + 1);
                cmdw2 = (wchar_t *)malloc(len * sizeof(wchar_t));
+               if (!cmdw2) {
+                       php_error_docref(NULL, E_WARNING, "Command conversion failed");
+                       goto exit_fail;
+               }
                ret = _snwprintf(cmdw2, len, L"%hs /c %s", COMSPEC_NT, cmdw);
 
                if (-1 == ret) {
+                       free(cmdw2);
                        php_error_docref(NULL, E_WARNING, "Command conversion failed");
                        goto exit_fail;
                }