Issue #19255: Clear error after failed PyDict_SetItem() on shutdown.

This silences a Coverity complain.

diff --git a/Objects/moduleobject.c b/Objects/moduleobject.c
index 2f2bd36b55d23fb19133a050c4de1e5991c1d0de..72978aef53a3227f58d3188b00452995f52790d8 100644 (file)
--- a/Objects/moduleobject.c
+++ b/Objects/moduleobject.c
@@ -300,7 +300,8 @@ _PyModule_Clear(PyObject *m)
                     else
                         PyErr_Clear();
                 }
-                PyDict_SetItem(d, key, Py_None);
+                if (PyDict_SetItem(d, key, Py_None) != 0)
+                    PyErr_Clear();
             }
         }
     }
@@ -319,7 +320,8 @@ _PyModule_Clear(PyObject *m)
                     else
                         PyErr_Clear();
                 }
-                PyDict_SetItem(d, key, Py_None);
+                if (PyDict_SetItem(d, key, Py_None) != 0)
+                    PyErr_Clear();
             }
         }
     }