]> granicus.if.org Git - llvm/commitdiff
ObjectFile makeTriple - silence static analyzer dyn_cast<COFFObjectFile> null derefer...
authorSimon Pilgrim <llvm-dev@redking.me.uk>
Tue, 1 Oct 2019 11:25:17 +0000 (11:25 +0000)
committerSimon Pilgrim <llvm-dev@redking.me.uk>
Tue, 1 Oct 2019 11:25:17 +0000 (11:25 +0000)
The static analyzer is warning about a potential null dereference, but we should be able to use cast<COFFObjectFile> directly and if not assert will fire for us.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@373324 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Object/ObjectFile.cpp

index bcc44cd6ce335c2ccf0ff472cc0a897bf30d304c..75e0952deb686f458054d620ffccaaf4d2c6a3c9 100644 (file)
@@ -105,7 +105,7 @@ Triple ObjectFile::makeTriple() const {
     TheTriple.setObjectFormat(Triple::MachO);
 
   if (isCOFF()) {
-    const auto COFFObj = dyn_cast<COFFObjectFile>(this);
+    const auto COFFObj = cast<COFFObjectFile>(this);
     if (COFFObj->getArch() == Triple::thumb)
       TheTriple.setTriple("thumbv7-windows");
   }