Fixed use of unitialized variable in lefty

In the file cmd/lefty/ws/x11/gquery.c, function Gqwpopaction:
THe char c is declared without initializer, giving it a unpredictable
value. If the next if statement takes the false branch, the function where
c is set is not executed. The next if statement then checks `c != 13`, but
because C could have any value, the behavior is unpredictable.
Initializing c with a known value, such as 0, fixes the problem.

diff --git a/cmd/lefty/ws/x11/gquery.c b/cmd/lefty/ws/x11/gquery.c
index 4851727829b89cd9a5ee38f5fe7869777344ab9a..7e42fe3f2b1a9f332d5ad027c93181f9d1cc9895 100644 (file)
--- a/cmd/lefty/ws/x11/gquery.c
+++ b/cmd/lefty/ws/x11/gquery.c
@@ -306,7 +306,7 @@ int GQqueryask (
 
 void Gqwpopaction (Widget w, XEvent *evp, char **app, unsigned int *anp) {
     Gwidget_t *widget;
-    char c;
+    char c = 0;
 
     if (evp->type == KeyPress || evp->type == KeyRelease)
         XLookupString ((XKeyEvent *) evp, &c, 1, NULL, NULL);