On win32, always open in binary mode unless they asked for text mode using 't'.

This solves a number of apparent BC breaks that resulted from the move from
fopen() to open().

diff --git a/main/streams.c b/main/streams.c
index 47b007a17081c5f54a7a7a759e1255e893c771b5..4af3c21f8be94f1cb051473e3c130342dd3aa2f6 100755 (executable)
--- a/main/streams.c
+++ b/main/streams.c
@@ -1912,14 +1912,11 @@ PHPAPI int php_stream_parse_fopen_modes(const char *mode, int *open_flags)
                flags |= O_RDONLY;
        }
 
-#ifdef O_BINARY
-       if (strchr(mode, 'b')) {
-               flags |= O_BINARY;
-       }
-#endif
-#ifdef _O_TEXT
+#if defined(_O_TEXT) && defined(O_BINARY)
        if (strchr(mode, 't')) {
                flags |= _O_TEXT;
+       } else {
+               flags |= O_BINARY;
        }
 #endif