Define buffer size macro and add a comment about the buffer size.

diff --git a/ext/fbsql/php_fbsql.c b/ext/fbsql/php_fbsql.c
index de5baa2473e429ffc7a729e10c0575b754b7f819..18c00ddc1e9e0d3426db6a0563c0789e1a6b5e26 100644 (file)
--- a/ext/fbsql/php_fbsql.c
+++ b/ext/fbsql/php_fbsql.c
@@ -163,6 +163,8 @@ struct PHPFBLink
 #define FBSQL_LOB_DIRECT 0                             /* default */
 #define FBSQL_LOB_HANDLE 1                             /* default */
 
+#define DIGEST_BUFFER_SIZE 17                  /* fbcDigestPassword() expects a preallocated buffer for 16 bytes plus termination */
+
 int mdOk(PHPFBLink* link, FBCMetaData* md, char* sql);
 char *DigestPassword(char *user, char *password)
 {
@@ -170,7 +172,7 @@ char *DigestPassword(char *user, char *password)
 
        if (user && strlen(user) && password && strlen(password)) {
                char *user_upper = estrdup(user);
-               digest = emalloc(17);
+               digest = emalloc(DIGEST_BUFFER_SIZE);
                digest[0] = '\0';
                (void)fbcDigestPassword(php_strtoupper(user_upper, strlen(user_upper)), password, digest);
                efree(user_upper);