top: circumvent a false positive smatch error

  The smatch error --------------
top.c +1414 calibrate_fields(78) error: buffer overflow 'Fieldstab' 39 <= 39

  The code -----------------------
if (P_MAXPFLGS < f) { w->endpflg = i; continue; }

  The background -----------------
The enum P_MAXPFLGS is strictly a fencepost and can *never* appear in
the arrays pflgsall or procflgs.  Thus it (39th element) cannot be used
in referencing Fieldstab.

However, two enums of higher value (X_XON=40 and X_XOF=41) *can* appear
in those arrays.  But the test against the fencepost ensures that those
two enums are *never* used in referencing Fieldstab.

When the analyzer sees the conditional using '<' and not '<='
it reports a false positive.

The source was changed to accommodate the tool's deficiency

diff --git a/top.c b/top.c
index 9ea19bb5d7626af554ed2ccbbfe0ba5c08560748..4b9fd4ec3ab977e7e3d3a04dbb3e1ed4989185f2 100644 (file)
--- a/top.c
+++ b/top.c
@@ -1409,7 +1409,7 @@ static void calibrate_fields (void) {
          for (i = w->totpflgs - 1; -1 < i; i--) {
             f = w->pflgsall[i];
 #ifndef USE_X_COLHDR
-            if (P_MAXPFLGS < f) { w->endpflg = i; continue; }
+            if (P_MAXPFLGS <= f) { w->endpflg = i; continue; }
 #endif
             h = Fieldstab[f].head;
             if (Screen_cols < ((int)(s - w->columnhdr) + (int)strlen(h))) break;