]> granicus.if.org Git - strace/commitdiff
tests: fix a few harmless -Woverflow compilation warnings
authorDmitry V. Levin <ldv@altlinux.org>
Wed, 16 Aug 2017 17:50:25 +0000 (17:50 +0000)
committerDmitry V. Levin <ldv@altlinux.org>
Wed, 16 Aug 2017 17:50:25 +0000 (17:50 +0000)
Fix the following compilation warnings on platforms where
sizeof(struct timeval.tv_usec) < sizeof(long):

xettimeofday.c: In function ‘main’:
xettimeofday.c:76:16: warning: overflow in implicit constant conversion [-Woverflow]
  tv->tv_usec = (long) 0xbadc0dedfacefeedLL;
xetitimer.c: In function ‘main’:
xetitimer.c:170:28: warning: overflow in implicit constant conversion [-Woverflow]
  p_new->it_value.tv_usec = (long) 0xbadc0dedfacefeedLL;
In file included from utimes.c:38:0:
xutimes.c: In function ‘main’:
xutimes.c:110:18: warning: overflow in implicit constant conversion [-Woverflow]
  tv[1].tv_usec = (long) 0xbadc0dedfacefeedLL;
futimesat.c: In function ‘main’:
futimesat.c:121:18: warning: overflow in implicit constant conversion [-Woverflow]
  tv[1].tv_usec = (long) 0xbadc0dedfacefeedLL;
In file included from _newselect.c:35:0:
xselect.c: In function ‘main’:
xselect.c:94:16: warning: overflow in implicit constant conversion [-Woverflow]
  tv->tv_usec = (long) 0xbadc0dedfacefeedLL;
                ^
* tests/futimesat.c (main): In initialization of struct timeval.tv_usec,
change explicit cast from (long) to (suseconds_t).
* tests/xetitimer.c: Likewise.
* tests/xettimeofday.c: Likewise.
* tests/xselect.c: Likewise.
* tests/xutimes.c: Likewise.

Reported-by: Anatoly Pugachev <matorola@gmail.com>
tests/futimesat.c
tests/xetitimer.c
tests/xettimeofday.c
tests/xselect.c
tests/xutimes.c

index 733fd09e7dcc6e8fec8c6d5fd57fdd679f8372b7..666ebdd80c09c1f7bdea002fca68858748cee9d8 100644 (file)
@@ -118,7 +118,7 @@ main(void)
        tv[0].tv_sec = 0xdeadbeefU;
        tv[0].tv_usec = 0xfacefeedU;
        tv[1].tv_sec = (time_t) 0xcafef00ddeadbeefLL;
-       tv[1].tv_usec = (long) 0xbadc0dedfacefeedLL;
+       tv[1].tv_usec = (suseconds_t) 0xbadc0dedfacefeedLL;
 
        k_futimesat(kfdcwd, kfname, (uintptr_t) tv);
        printf("futimesat(AT_FDCWD, %s, [", qname);
index 3a8188037aee6addd114ad7db272eac0c1cf1ddf..f9cfe0b943238391385982fe13a74e5d09be5072 100644 (file)
@@ -167,7 +167,7 @@ main(void)
        p_new->it_interval.tv_sec = 0xdeadbeefU;
        p_new->it_interval.tv_usec = 0xfacefeedU;
        p_new->it_value.tv_sec = (time_t) 0xcafef00ddeadbeefLL;
-       p_new->it_value.tv_usec = (long) 0xbadc0dedfacefeedLL;
+       p_new->it_value.tv_usec = (suseconds_t) 0xbadc0dedfacefeedLL;
 
        rc = setitimer(ITIMER_REAL, p_new, p_old);
        printf("setitimer(ITIMER_REAL"
index ec422cf53b894d29016ce1ed5d79edc4ef8ca898..8652b24c65e4ba61d32c621cf7208711090b61b5 100644 (file)
@@ -73,7 +73,7 @@ main(void)
               tz->tz_minuteswest, tz->tz_dsttime);
 
        tv->tv_sec = (time_t) 0xcafef00ddeadbeefLL;
-       tv->tv_usec = (long) 0xbadc0dedfacefeedLL;
+       tv->tv_usec = (suseconds_t) 0xbadc0dedfacefeedLL;
        assert(syscall(__NR_settimeofday, tv, tz) == -1);
        printf("settimeofday({tv_sec=%lld, tv_usec=%llu}"
               ", {tz_minuteswest=%d, tz_dsttime=%d}) = -1 EINVAL (%m)\n",
index 6c8cd81eaf03301a858a98463465d051c4307a54..a25ebcc6508d8115723a92993b3a99277cd5348f 100644 (file)
@@ -91,7 +91,7 @@ int main(void)
        FD_SET(fds[0], set);
        FD_SET(fds[1], set);
        tv->tv_sec = (time_t) 0xcafef00ddeadbeefLL;
-       tv->tv_usec = (long) 0xbadc0dedfacefeedLL;
+       tv->tv_usec = (suseconds_t) 0xbadc0dedfacefeedLL;
        memcpy(&tv_in, tv, sizeof(tv_in));
        rc = syscall(TEST_SYSCALL_NR, fds[1] + 1, set, set, set, tv);
        if (rc < 0) {
index 5fd7161a6fdedf82f5e12fd6afc7b24d4be4381b..23728a1ede38b96d61f587eddf30f00d02a7eca2 100644 (file)
@@ -107,7 +107,7 @@ main(void)
        tv[0].tv_sec = 0xdeadbeefU;
        tv[0].tv_usec = 0xfacefeedU;
        tv[1].tv_sec = (time_t) 0xcafef00ddeadbeefLL;
-       tv[1].tv_usec = (long) 0xbadc0dedfacefeedLL;
+       tv[1].tv_usec = (suseconds_t) 0xbadc0dedfacefeedLL;
 
        k_utimes(kfname, (uintptr_t) tv);
        printf("%s(%s, [", TEST_SYSCALL_STR, qname);