]> granicus.if.org Git - llvm/commitdiff
[lit] Fix type error for parallelism groups
authorBrian Gesiak <modocache@gmail.com>
Wed, 26 Jul 2017 15:02:05 +0000 (15:02 +0000)
committerBrian Gesiak <modocache@gmail.com>
Wed, 26 Jul 2017 15:02:05 +0000 (15:02 +0000)
Summary:
Whereas rL299560 and rL309071 call `parallelism_groups.items()`, under the
assumption that `parallelism_groups` is a `dict` type, the default
parameter for that attribute is a `list`. Change the default to a
`dict` for type correctness.

This regression in the unit tests would have been caught if the
unit tests were being run continously. It also would have been caught
if the lit project used a Python type checker such as `mypy`.

Test Plan:
As per the instructions in `utils/lit/README.txt`, run the lit unit
test suite:

```
utils/lit/lit.py \
    --path /path/to/your/llvm/build/bin \
    utils/lit/tests
```

Verify that the test `lit :: unit/TestRunner.py` fails before applying this
patch, but passes once this patch is applied.

Reviewers: mgorny, rnk, rafael

Reviewed By: mgorny

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D35878

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@309122 91177308-0d34-0410-b5e6-96231b3b80d8

utils/lit/lit/LitConfig.py

index 2ef0a8f77ec99a90beb9005c3e977a2a54b44b29..3351ebed54bdb215ebe58ec21b5f570a2d5b21c4 100644 (file)
@@ -25,7 +25,7 @@ class LitConfig(object):
                  params, config_prefix = None,
                  maxIndividualTestTime = 0,
                  maxFailures = None,
-                 parallelism_groups = [],
+                 parallelism_groups = {},
                  echo_all_commands = False):
         # The name of the test runner.
         self.progname = progname