Don't allow foreign tables with OIDs.

The syntax doesn't let you specify "WITH OIDS" for foreign tables, but it
was still possible with default_with_oids=true. But the rest of the system,
including pg_dump, isn't prepared to handle foreign tables with OIDs
properly.

Backpatch down to 9.1, where foreign tables were introduced. It's possible
that there are databases out there that already have foreign tables with
OIDs. There isn't much we can do about that, but at least we can prevent
them from being created in the future.

Patch by Etsuro Fujita, reviewed by Hadi Moshayedi.

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 6136e546a196c90864f9846133c6765fbad4f1bf..288757aa5083c53946f7e26f68f659a5f7ce7ffc 100644 (file)
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -550,7 +550,10 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId)
         */
        descriptor = BuildDescForRelation(schema);
 
-       localHasOids = interpretOidsOption(stmt->options);
+       if (relkind == RELKIND_FOREIGN_TABLE)
+               localHasOids = false;
+       else
+               localHasOids = interpretOidsOption(stmt->options);
        descriptor->tdhasoid = (localHasOids || parentOidCount > 0);
 
        /*