proc/readproc.c: Harden simple_nextpid().

Replace memcpy+strcpy with snprintf.

diff --git a/proc/readproc.c b/proc/readproc.c
index 18644ffb675593b2d07705241d6ef01cfbba61d2..aaa8a29c6d28e4a5783f90425ac1669aa2eab1c5 100644 (file)
--- a/proc/readproc.c
+++ b/proc/readproc.c
@@ -1224,8 +1224,7 @@ static int simple_nextpid(PROCTAB *restrict const PT, proc_t *restrict const p)
   }
   p->tgid = strtoul(ent->d_name, NULL, 10);
   p->tid = p->tgid;
-  memcpy(path, "/proc/", 6);
-  strcpy(path+6, ent->d_name);  // trust /proc to not contain evil top-level entries
+  snprintf(path, PROCPATHLEN, "/proc/%s", ent->d_name);
   return 1;
 }