Add forgotten CHECK_FOR_INTERRUPT calls in pgcrypto's crypt()

Both Blowfish and DES implementations of crypt() can take arbitrarily
long time, depending on the number of rounds specified by the caller;
make sure they can be interrupted.

Author: Andreas Karlsson
Reviewer: Jeff Janes

Backpatch to 9.1.

diff --git a/contrib/pgcrypto/crypt-blowfish.c b/contrib/pgcrypto/crypt-blowfish.c
index aec7c00cdb9d5945000651417d84ffe3f30d2456..dc88593bc1e13fc613155790fc695912824a812d 100644 (file)
--- a/contrib/pgcrypto/crypt-blowfish.c
+++ b/contrib/pgcrypto/crypt-blowfish.c
@@ -33,6 +33,7 @@
  */
 
 #include "postgres.h"
+#include "miscadmin.h"
 
 #include "px-crypt.h"
 #include "px.h"
@@ -670,6 +671,8 @@ _crypt_blowfish_rn(const char *key, const char *setting,
 
        do
        {
+               CHECK_FOR_INTERRUPTS();
+
                data.ctx.P[0] ^= data.expanded_key[0];
                data.ctx.P[1] ^= data.expanded_key[1];
                data.ctx.P[2] ^= data.expanded_key[2];

diff --git a/contrib/pgcrypto/crypt-des.c b/contrib/pgcrypto/crypt-des.c
index 6834c28cf2ff5b3f78fe551f8d7e0e4778ed2010..e2501787a027b5b59c4eb9ab2ba1fa5f8ea465f4 100644 (file)
--- a/contrib/pgcrypto/crypt-des.c
+++ b/contrib/pgcrypto/crypt-des.c
@@ -61,6 +61,7 @@
  */
 
 #include "postgres.h"
+#include "miscadmin.h"
 
 #include "px.h"
 #include "px-crypt.h"
@@ -541,6 +542,8 @@ do_des(uint32 l_in, uint32 r_in, uint32 *l_out, uint32 *r_out, int count)
 
        while (count--)
        {
+               CHECK_FOR_INTERRUPTS();
+
                /*
                 * Do each round.
                 */