]> granicus.if.org Git - strace/commitdiff
tests/lseek.c: cleanup
authorDmitry V. Levin <ldv@altlinux.org>
Thu, 21 Apr 2016 21:01:40 +0000 (21:01 +0000)
committerDmitry V. Levin <ldv@altlinux.org>
Thu, 21 Apr 2016 22:05:55 +0000 (22:05 +0000)
* tests/lseek.c (main): Use errno2name, stop using assert.

tests/lseek.c

index 227c4e301a2a26ea54de6dc62c25f84814026b9c..72efc6e2c75492404a3b74375397890536424df5 100644 (file)
@@ -41,20 +41,19 @@ main(void)
 {
        const kernel_ulong_t offset = (kernel_ulong_t) 0xfacefeeddeadbeefULL;
 
-       if (sizeof(offset) > sizeof(long))
-               assert(lseek(-1, offset, SEEK_SET) == -1);
-       else
-               assert(syscall(__NR_lseek, -1L, offset, SEEK_SET) == -1);
-
-       if (EBADF != errno)
-               perror_msg_and_skip("lseek");
-
-       if (sizeof(offset) > sizeof(long))
-               printf("lseek(-1, %lld, SEEK_SET) = -1 EBADF (%m)\n",
-                      (long long) offset);
-       else
-               printf("lseek(-1, %ld, SEEK_SET) = -1 EBADF (%m)\n",
-                      (long) offset);
+       if (sizeof(offset) > sizeof(long)) {
+               /*
+                * Cannot use syscall because it takes long arguments.
+                * Let's call lseek with hope it will invoke lseek syscall.
+                */
+               long long rc = lseek(-1, offset, SEEK_SET);
+               printf("lseek(-1, %lld, SEEK_SET) = %lld %s (%m)\n",
+                      (long long) offset, rc, errno2name());
+       } else {
+               long rc = syscall(__NR_lseek, -1L, offset, SEEK_SET);
+               printf("lseek(-1, %ld, SEEK_SET) = %ld %s (%m)\n",
+                      (long) offset, rc, errno2name());
+       }
 
        puts("+++ exited with 0 +++");
        return 0;