Fix ID3v2 padding size calculation.
authorTsuda Kageyu <tsuda.kageyu@gmail.com>
Tue, 9 Dec 2014 01:54:21 +0000 (10:54 +0900)
committerTsuda Kageyu <tsuda.kageyu@gmail.com>
Tue, 9 Dec 2014 01:54:21 +0000 (10:54 +0900)
taglib/mpeg/id3v2/id3v2tag.cpp

index e8fa23df8ccd74a78e13c479acb2c73d42827f29..267a45d04e1b27da78b9f5e0fdf3c46a63c6c14c 100644 (file)
@@ -608,9 +608,11 @@ ByteVector ID3v2::Tag::render(int version) const
 
     // Padding won't increase beyond 1% of the file size.
 
-    const uint threshold = d->file->length() / 100; // should be ulonglong in taglib2.
-    if(paddingSize > d->paddingSize && paddingSize > threshold)
-      paddingSize = DefaultPaddingSize;
+    if(paddingSize > DefaultPaddingSize) {
+      const uint threshold = d->file->length() / 100; // should be ulonglong in taglib2.
+      if(paddingSize > threshold)
+        paddingSize = DefaultPaddingSize;
+    }
   }
 
   tagData.append(ByteVector(paddingSize, '\0'));