]> granicus.if.org Git - python/commitdiff
test_selectors: test_timeout fails sometimes on busy (slow) buildbots, relax
authorVictor Stinner <victor.stinner@gmail.com>
Sun, 17 Nov 2013 22:46:34 +0000 (23:46 +0100)
committerVictor Stinner <victor.stinner@gmail.com>
Sun, 17 Nov 2013 22:46:34 +0000 (23:46 +0100)
the unit test on max time (but be more strict on mon time). Example of failure:

http://buildbot.python.org/all/builders/x86%20OpenIndiana%203.x/builds/6978/steps/test/logs/stdio

======================================================================
FAIL: test_timeout (test.test_selectors.PollSelectorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/export/home/buildbot/32bits/3.x.cea-indiana-x86/build/Lib/test/test_selectors.py", line 316, in test_timeout
    self.assertTrue(0.5 < t1 - t0 < 1.5, t1 - t0)
AssertionError: False is not true : 1.5033390671014786

Lib/test/test_selectors.py

index c64c87aa3f7b1a9fa99c6ffea2745852e6f689f6..f5e67b1005986d8687a3402b9ffb23c5a2561a71 100644 (file)
@@ -313,7 +313,8 @@ class BaseSelectorTestCase(unittest.TestCase):
         t0 = time()
         self.assertFalse(s.select(1))
         t1 = time()
-        self.assertTrue(0.5 < t1 - t0 < 1.5, t1 - t0)
+        dt = t1 - t0
+        self.assertTrue(0.8 <= dt <= 1.6, dt)
 
     @unittest.skipUnless(hasattr(signal, "alarm"),
                          "signal.alarm() required for this test")