#7310: fix the repr() of os.environ

diff --git a/Lib/os.py b/Lib/os.py
index a64098435317845d45ebb175ee639208c18043d3..1c5b5ce2eaaf2cb43e01099bc41f8a5253e3db9c 100644 (file)
--- a/Lib/os.py
+++ b/Lib/os.py
@@ -387,22 +387,32 @@ class _Environ(MutableMapping):
         self.data = data = {}
         for key, value in environ.items():
             data[keymap(key)] = str(value)
+
     def __getitem__(self, key):
         return self.data[self.keymap(key)]
+
     def __setitem__(self, key, value):
         value = str(value)
         self.putenv(key, value)
         self.data[self.keymap(key)] = value
+
     def __delitem__(self, key):
         self.unsetenv(key)
         del self.data[self.keymap(key)]
+
     def __iter__(self):
         for key in self.data:
             yield key
+
     def __len__(self):
         return len(self.data)
+
+    def __repr__(self):
+        return 'environ({!r})'.format(self.data)
+
     def copy(self):
         return dict(self)
+
     def setdefault(self, key, value):
         if key not in self:
             self[key] = value

diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
index cdbc9983747afed4e96bf4099eb509d6c7304d9e..1ff356c099043f36b2a8d8cbc0b94245ee465a22 100644 (file)
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -400,6 +400,14 @@ class EnvironTests(mapping_tests.BasicTestMappingProtocol):
         for key, value in self._reference().items():
             self.assertEqual(os.environ.get(key), value)
 
+    # Issue 7310
+    def test___repr__(self):
+        """Check that the repr() of os.environ looks like environ({...})."""
+        env = os.environ
+        self.assertTrue(isinstance(env.data, dict))
+        self.assertEqual(repr(env), 'environ({!r})'.format(env.data))
+
+
 class WalkTests(unittest.TestCase):
     """Tests for os.walk()."""
 

diff --git a/Misc/NEWS b/Misc/NEWS
index 021b31a05fb766b4255691d232d980fa86d53c6f..2db7bc18e0cae333f96c4f7864322cfe9429cbcc 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -247,6 +247,8 @@ C-API
 Library
 -------
 
+- Issue #7310: fix the __repr__ of os.environ to show the environment variables.
+
 - Issue #7970: email.Generator.flatten now correctly flattens message/rfc822
   messages parsed by email.Parser.HeaderParser.