]> granicus.if.org Git - php/commitdiff
0 byte file uploads are valid, avoid choking on them
authorZeev Suraski <zeev@php.net>
Sat, 11 May 2002 11:58:16 +0000 (11:58 +0000)
committerZeev Suraski <zeev@php.net>
Sat, 11 May 2002 11:58:16 +0000 (11:58 +0000)
main/rfc1867.c

index 84c6078e388862e81a64c6d9c61df5022e24f135..6fad7eb3afbe6566ee247beee6e930d142c049dd 100644 (file)
@@ -33,6 +33,8 @@
 #include "rfc1867.h"
 
 
+#undef DEBUG_FILE_UPLOAD
+
 #define SAFE_RETURN { \
        if (lbuf) efree(lbuf); \
        if (abuf) efree(abuf); \
@@ -752,19 +754,19 @@ SAPI_API SAPI_POST_HANDLER_FUNC(rfc1867_post_handler)
                        } 
                        fclose(fp);
 
+#ifdef DEBUG_FILE_UPLOAD
                        if(strlen(filename) > 0 && total_bytes == 0) {
                                sapi_module.sapi_error(E_WARNING, "Uploaded file size 0 - file [%s=%s] not saved", param, filename);
                                cancel_upload = UPLOAD_ERROR_E;
                        }
-                       
-                       if (cancel_upload || total_bytes == 0) {
+#endif         
 
+                       if (cancel_upload) {
                                if (temp_filename) {
                                        unlink(temp_filename);
                                        efree(temp_filename);
                                }
                                temp_filename="";
-
                        } else {
                                zend_hash_add(SG(rfc1867_uploaded_files), temp_filename, strlen(temp_filename) + 1, &temp_filename, sizeof(char *), NULL);
                        }