]> granicus.if.org Git - cgit/commitdiff
ui-ssdiff.c: set correct diffmode in "control panel"
authorTim Chen <timchen1@gmail.com>
Tue, 3 Jan 2012 16:09:59 +0000 (16:09 +0000)
committerLars Hjemli <hjemli@gmail.com>
Tue, 3 Jan 2012 16:09:59 +0000 (16:09 +0000)
When side-by-side-diffs=1 was set in cgitrc, specifying 'ss=0' in the
querystring would not set the 'unified' option as active in the dropdown
box used to select diffmode.

ui-diff.c

index af24a6c4ccffa1520f383748f574dd87d0945b52..c6bad6374b0f1074b6cd7d86ea37c9c857365754 100644 (file)
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -341,9 +341,7 @@ void cgit_print_diff_ctrls()
        html("<td class='label'>mode:</td>");
        html("<td class='ctrl'>");
        html("<select name='ss' onchange='this.form.submit();'>");
-       curr = ctx.qry.ssdiff;
-       if (!curr && ctx.cfg.ssdiff)
-               curr = 1;
+       curr = ctx.qry.has_ssdiff ? ctx.qry.ssdiff : ctx.cfg.ssdiff;
        html_intoption(0, "unified", curr);
        html_intoption(1, "ssdiff", curr);
        html("</select></td></tr>");