]> granicus.if.org Git - php/commitdiff
Don't explicitly set return value on ZPP failure
authorChristoph M. Becker <cmbecker69@gmx.de>
Mon, 12 Aug 2019 08:01:30 +0000 (10:01 +0200)
committerChristoph M. Becker <cmbecker69@gmx.de>
Mon, 12 Aug 2019 08:02:45 +0000 (10:02 +0200)
Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return
value is useless, and also slightly confusing.

ext/com_dotnet/com_com.c

index a16d5396d8d900da447fa44f97a94fc84af06235..f9d88603c7bc4cb8fa7ffa5a221a7d5fb704042e 100644 (file)
@@ -701,7 +701,7 @@ PHP_FUNCTION(com_event_sink)
 
        if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "Oo|z/",
                        &object, php_com_variant_class_entry, &sinkobject, &sink)) {
-               RETURN_FALSE;
+               return;
        }
 
        php_com_initialize();
@@ -762,7 +762,7 @@ PHP_FUNCTION(com_print_typeinfo)
 
        if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "z/|s!b", &arg1, &ifacename,
                                &ifacelen, &wantsink)) {
-               RETURN_FALSE;
+               return;
        }
 
        php_com_initialize();