Make pg_controldata report newest XID with valid commit timestamp

Previously pg_controldata didn't report newestCommitTs and this was
an oversight in commit 73c986a.

Also this patch changes pg_resetxlog so that it uses the same sentences
as pg_controldata does, regarding oldestCommitTs and newestCommitTs,
for the sake of consistency.

Back-patch to 9.5 where track_commit_timestamp was added.

Euler Taveira

diff --git a/src/bin/pg_controldata/pg_controldata.c b/src/bin/pg_controldata/pg_controldata.c
index 704f72d3c503015b87b4ace48c530896a14f47dd..32e1d81bf20fdb5fbbde6b459eadf2221199fa4b 100644 (file)
--- a/src/bin/pg_controldata/pg_controldata.c
+++ b/src/bin/pg_controldata/pg_controldata.c
@@ -273,6 +273,8 @@ main(int argc, char *argv[])
                   ControlFile.checkPointCopy.oldestMultiDB);
        printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
                   ControlFile.checkPointCopy.oldestCommitTs);
+       printf(_("Latest checkpoint's newestCommitTs:   %u\n"),
+                  ControlFile.checkPointCopy.newestCommitTs);
        printf(_("Time of latest checkpoint:            %s\n"),
                   ckpttime_str);
        printf(_("Fake LSN counter for unlogged rels:   %X/%X\n"),

diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
index c8c1ac32880d54ccbee48bc164637006219a18c0..d7ac2ba2715dc9771895e69c5780ad55951a8aac 100644 (file)
--- a/src/bin/pg_resetxlog/pg_resetxlog.c
+++ b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -665,9 +665,9 @@ PrintControlValues(bool guessed)
                   ControlFile.checkPointCopy.oldestMulti);
        printf(_("Latest checkpoint's oldestMulti's DB: %u\n"),
                   ControlFile.checkPointCopy.oldestMultiDB);
-       printf(_("Latest checkpoint's oldest CommitTs:  %u\n"),
+       printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
                   ControlFile.checkPointCopy.oldestCommitTs);
-       printf(_("Latest checkpoint's newest CommitTs:  %u\n"),
+       printf(_("Latest checkpoint's newestCommitTs:   %u\n"),
                   ControlFile.checkPointCopy.newestCommitTs);
        printf(_("Maximum data alignment:               %u\n"),
                   ControlFile.maxAlign);