Issue #15759: "make suspicious", "make linkcheck" and "make doctest" in Doc/

now display special message when and only when there are failures.

diff --git a/Doc/Makefile b/Doc/Makefile
index 370c3faa3bda84f68596d68cdbd8df7610d0c9cf..43dd80478a1e6b1fa0dfbd6c1e50baa7c40d3661 100644 (file)
--- a/Doc/Makefile
+++ b/Doc/Makefile
@@ -69,24 +69,30 @@ changes: build
        @echo "The overview file is in build/changes."
 
 linkcheck: BUILDER = linkcheck
-linkcheck: build
-       @echo "Link check complete; look for any errors in the above output" \
-             "or in build/$(BUILDER)/output.txt"
+linkcheck:
+       @$(MAKE) build BUILDER=$(BUILDER) || { \
+       echo "Link check complete; look for any errors in the above output" \
+            "or in build/$(BUILDER)/output.txt"; \
+       false; }
 
 suspicious: BUILDER = suspicious
-suspicious: build
-       @echo "Suspicious check complete; look for any errors in the above output" \
-             "or in build/$(BUILDER)/suspicious.csv.  If all issues are false" \
-             "positives, append that file to tools/sphinxext/susp-ignored.csv."
+suspicious:
+       @$(MAKE) build BUILDER=$(BUILDER) || { \
+       echo "Suspicious check complete; look for any errors in the above output" \
+            "or in build/$(BUILDER)/suspicious.csv.  If all issues are false" \
+            "positives, append that file to tools/sphinxext/susp-ignored.csv."; \
+       false; }
 
 coverage: BUILDER = coverage
 coverage: build
        @echo "Coverage finished; see c.txt and python.txt in build/coverage"
 
 doctest: BUILDER = doctest
-doctest: build
-       @echo "Testing of doctests in the sources finished, look at the" \
-             "results in build/doctest/output.txt"
+doctest:
+       @$(MAKE) build BUILDER=$(BUILDER) || { \
+       echo "Testing of doctests in the sources finished, look at the" \
+            "results in build/doctest/output.txt"; \
+       false; }
 
 pydoc-topics: BUILDER = pydoc-topics
 pydoc-topics: build

diff --git a/Misc/NEWS b/Misc/NEWS
index 077b3a30947a9074a11f16685cb15d0172cf1ad1..2a6f24f23918759f756292630cede6b5255aff1e 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -169,6 +169,9 @@ Library
 Build
 -----
 
+- Issue #15759: "make suspicious", "make linkcheck" and "make doctest" in Doc/
+  now display special message when and only when there are failures.
+
 - Issue #17095: Fix Modules/Setup *shared* support.
 
 - Issue #21811: Anticipated fixes to support OS X versions > 10.9.