]> granicus.if.org Git - python/commitdiff
Forgot the "empty string -> hash == 0" special case for strings.
authorGeorg Brandl <georg@python.org>
Mon, 20 Feb 2012 23:50:13 +0000 (00:50 +0100)
committerGeorg Brandl <georg@python.org>
Mon, 20 Feb 2012 23:50:13 +0000 (00:50 +0100)
Objects/unicodeobject.c

index 716ca3f26a435cd8225ad05adef52204bfd06b67..75e9923f0d7765cea9d677364aea0a78d1d2e691 100644 (file)
@@ -11219,6 +11219,14 @@ unicode_hash(PyObject *self)
     if (PyUnicode_READY(self) == -1)
         return -1;
     len = PyUnicode_GET_LENGTH(self);
+    /*
+      We make the hash of the empty string be 0, rather than using
+      (prefix ^ suffix), since this slightly obfuscates the hash secret
+    */
+    if (len == 0) {
+        _PyUnicode_HASH(self) = 0;
+        return 0;
+    }
 
     /* The hash function as a macro, gets expanded three times below. */
 #define HASH(P)                                            \