]> granicus.if.org Git - php/commitdiff
MFH
authorIlia Alshanetsky <iliaa@php.net>
Tue, 4 Feb 2003 18:34:10 +0000 (18:34 +0000)
committerIlia Alshanetsky <iliaa@php.net>
Tue, 4 Feb 2003 18:34:10 +0000 (18:34 +0000)
ext/pgsql/pgsql.c

index a8a24193d43c06923b1e199d1f139ce64821c569..b72931119fbacce8983a4adcdcd5fc3b73373ef4 100644 (file)
@@ -1437,23 +1437,18 @@ PHP_FUNCTION(pg_result_seek)
        int row;
        pgsql_result_handle *pg_result;
 
-       if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "r|l",
-                                                         &result, &row) == FAILURE) {
+       if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rl", &result, &row) == FAILURE) {
                return;
        }
 
        ZEND_FETCH_RESOURCE(pg_result, pgsql_result_handle *, &result, -1, "PostgreSQL result", le_result);
 
-       /* Let see if we are better to have another function for this */
-       /* if offset is omitted, return current position */
-/*     if (ZEND_NUM_ARGS() == 1) */
-/*             RETURN_LONG(pg_result->row); */
-
-       if (row < 0 || row >= PQntuples(pg_result->result))
+       if (row < 0 || row >= PQntuples(pg_result->result)) {
                RETURN_FALSE;
+       }
        
        /* seek to offset */
-       pg_result->row = row;
+       pg_result->row = row - 1;
        RETURN_TRUE;
 }
 /* }}} */