revert the changes done for issue14826 - quoting witin Request is not desirable.
authorSenthil Kumaran <senthil@uthcode.com>
Mon, 9 Jul 2012 00:47:25 +0000 (17:47 -0700)
committerSenthil Kumaran <senthil@uthcode.com>
Mon, 9 Jul 2012 00:47:25 +0000 (17:47 -0700)
Lib/test/test_urllib.py
Lib/urllib/request.py
Misc/NEWS

index 69d543855e5cf8f004704f16be58c5bb323f49e8..c6f6f6121f37823a59a7799746ed4c9039c4421d 100644 (file)
@@ -1246,11 +1246,6 @@ class URLopener_Tests(unittest.TestCase):
 #         ftp.close()
 
 
-    def test_quote_url(self):
-        Request = urllib.request.Request
-        request = Request("http://www.python.org/foo bar")
-        self.assertEqual(request.full_url, "http://www.python.org/foo%20bar")
-
 
 def test_main():
     support.run_unittest(
index c77697c57689e3fc3d6ff5a4119777863ab8919d..d6f9f9a1bcaa8efc186d9499da9fb781eed84068 100644 (file)
@@ -181,7 +181,6 @@ class Request:
                  origin_req_host=None, unverifiable=False):
         # unwrap('<URL:type://host/path>') --> 'type://host/path'
         self.full_url = unwrap(url)
-        self.full_url = quote(self.full_url, safe="%/:=&?~#+!$,;'@()*[]|")
         self.full_url, self.fragment = splittag(self.full_url)
         self.data = data
         self.headers = {}
index 2e2b03fb654b2a910785598b3ea36101e1e12386..fe838975535098d1a769eecefb0374b6d922432e 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -87,11 +87,6 @@ Core and Builtins
 Library
 -------
 
-- Issue #14826: Quote urls in urllib.request.Request similar to how they are
-  quoted by urllib.request.URLopener. Allows urls to spaces in them to work
-  transparently with urllib.request.urlopen(...). Patch contributed by Stephen
-  Thorne.
-
 - Issue #14990: Correctly fail with SyntaxError on invalid encoding
   declaration.