no need to check for NULL pointers before dereferencing, as the pointers

MUST be valid and they are dereferenced further down in the function
unconditionally!

diff --git a/ares/ares_parse_srv_reply.c b/ares/ares_parse_srv_reply.c
index b0e15eb0f1faa649f6f3b9f7e9dddd628a833c28..3a17a5334489cf8adc37e7ce23424e8923f263d5 100644 (file)
--- a/ares/ares_parse_srv_reply.c
+++ b/ares/ares_parse_srv_reply.c
@@ -64,11 +64,10 @@ ares_parse_srv_reply (const unsigned char *abuf, int alen,
   struct ares_srv_reply *srv = NULL;
 
   /* Set *srv_out to NULL for all failure cases. */
-  if (srv_out)
-    *srv_out = NULL;
+  *srv_out = NULL;
+
   /* Same with *nsrvreply. */
-  if (nsrvreply)
-    *nsrvreply = 0;
+  *nsrvreply = 0;
 
   /* Give up if abuf doesn't have room for a header. */
   if (alen < HFIXEDSZ)