Fix bug 231273 - [windows] os.popen doens't kill subprocess when interrupted

Don't pass CREATE_NEW_CONSOLE to CreateProcess(), meaning our child process is in the same "console group" and therefore interrupted by the same Ctrl+C that interrupts the parent.

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 4d9c93d592754e3b70babc132b71e03a9e46f88d..8a419c3ad809545adb028f161d33420db5a4733a 100644 (file)
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -3291,7 +3291,7 @@ _PyPopenCreateProcess(char *cmdstring,
                          NULL,
                          NULL,
                          TRUE,
-                         CREATE_NEW_CONSOLE,
+                         0, /* no new console so Ctrl+C kills child too */
                          NULL,
                          NULL,
                          &siStartInfo,