Fix bug #53279 (SplFileObject doesn't initialise default CSV escape character).
authorAdam Harvey <aharvey@php.net>
Tue, 9 Nov 2010 14:53:23 +0000 (14:53 +0000)
committerAdam Harvey <aharvey@php.net>
Tue, 9 Nov 2010 14:53:23 +0000 (14:53 +0000)
ext/spl/spl_directory.c
ext/spl/tests/SplFileObject_fgetcsv_escape_default.phpt [new file with mode: 0644]

index d02a95b59daf13d4e5444bf9df52b872d490681e..0d6cfa269e84867ea51436cfe981dde8c4e6d65a 100755 (executable)
@@ -274,6 +274,7 @@ static int spl_filesystem_file_open(spl_filesystem_object *intern, int use_inclu
        
        intern->u.file.delimiter = ',';
        intern->u.file.enclosure = '"';
+       intern->u.file.escape = '\\';
 
        zend_hash_find(&intern->std.ce->function_table, "getcurrentline", sizeof("getcurrentline"), (void **) &intern->u.file.func_getCurr);
 
diff --git a/ext/spl/tests/SplFileObject_fgetcsv_escape_default.phpt b/ext/spl/tests/SplFileObject_fgetcsv_escape_default.phpt
new file mode 100644 (file)
index 0000000..b3b6c7c
--- /dev/null
@@ -0,0 +1,24 @@
+--TEST--
+SplFileObject::fgetcsv with default escape character
+--FILE--
+<?php
+$fp = fopen('SplFileObject::fgetcsv.csv', 'w+');
+fwrite($fp, '"aa\"","bb","\"c"');
+fclose($fp);
+
+$fo = new SplFileObject('SplFileObject::fgetcsv.csv');
+var_dump($fo->fgetcsv());
+?>
+--CLEAN--
+<?php
+unlink('SplFileObject::fgetcsv.csv');
+?>
+--EXPECTF--
+array(3) {
+  [0]=>
+  string(4) "aa\""
+  [1]=>
+  string(2) "bb"
+  [2]=>
+  string(3) "\"c"
+}