add_next_timeout: minor restructure of code

By reading the ->head pointer and using that instead of the ->size
number to figure out if there's a list remaining we avoid the (false
positive) clang-analyzer warning that we might dereference of a null
pointer.

diff --git a/lib/multi.c b/lib/multi.c
index ff43378f561dfa34a50a3b05b17326b9943b735a..d252351b7e1c8e0a05e1e843420992c3fab03c2e 100644 (file)
--- a/lib/multi.c
+++ b/lib/multi.c
@@ -2079,14 +2079,14 @@ static CURLMcode add_next_timeout(struct timeval now,
       break;
     e = n;
   }
-  if(!list->size)  {
+  e = list->head;
+  if(!e) {
     /* clear the expire times within the handles that we remove from the
        splay tree */
     tv->tv_sec = 0;
     tv->tv_usec = 0;
   }
   else {
-    e = list->head;
     /* copy the first entry to 'tv' */
     memcpy(tv, e->ptr, sizeof(*tv));