]> granicus.if.org Git - clang/commitdiff
DiagnosticsEngine: update severity setters to new terminology
authorAlp Toker <alp@nuanti.com>
Thu, 12 Jun 2014 11:13:52 +0000 (11:13 +0000)
committerAlp Toker <alp@nuanti.com>
Thu, 12 Jun 2014 11:13:52 +0000 (11:13 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@210764 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/Basic/Diagnostic.h
lib/ARCMigrate/ARCMT.cpp
lib/Basic/Diagnostic.cpp
lib/Basic/Warnings.cpp
lib/Lex/Pragma.cpp
lib/Parse/ParsePragma.cpp

index 45a337d0ce557067d1163974f8a7fb463944a3aa..f16c0d391ffaeecfa9e748fd5d35812db1d22abc 100644 (file)
@@ -544,8 +544,7 @@ public:
   ///
   /// \param Loc The source location that this change of diagnostic state should
   /// take affect. It can be null if we are setting the latest state.
-  void setDiagnosticMapping(diag::kind Diag, diag::Severity Map,
-                            SourceLocation Loc);
+  void setSeverity(diag::kind Diag, diag::Severity Map, SourceLocation Loc);
 
   /// \brief Change an entire diagnostic group (e.g. "unknown-pragmas") to
   /// have the specified mapping.
@@ -555,8 +554,8 @@ public:
   ///
   /// \param Loc The source location that this change of diagnostic state should
   /// take affect. It can be null if we are setting the state from command-line.
-  bool setDiagnosticGroupMapping(StringRef Group, diag::Severity Map,
-                                 SourceLocation Loc = SourceLocation());
+  bool setSeverityForGroup(StringRef Group, diag::Severity Map,
+                           SourceLocation Loc = SourceLocation());
 
   /// \brief Set the warning-as-error flag for the given diagnostic group.
   ///
@@ -576,8 +575,8 @@ public:
   ///
   /// Mainly to be used by -Wno-everything to disable all warnings but allow
   /// subsequent -W options to enable specific warnings.
-  void setMappingForAllDiagnostics(diag::Severity Map,
-                                   SourceLocation Loc = SourceLocation());
+  void setSeverityForAll(diag::Severity Map,
+                         SourceLocation Loc = SourceLocation());
 
   bool hasErrorOccurred() const { return ErrorOccurred; }
 
index 6032b001d33843363a22fb8af3aff0a2d6505433..8a13b2ee4f1d04c7d5da7f06ab4422a5aa8e316e 100644 (file)
@@ -312,8 +312,8 @@ bool arcmt::checkForManualIssues(CompilerInvocation &origCI,
                      ARCMTMacroLocs);
   pass.setNoFinalizeRemoval(NoFinalizeRemoval);
   if (!NoNSAllocReallocError)
-    Diags->setDiagnosticMapping(diag::warn_arcmt_nsalloc_realloc,
-                                diag::Severity::Error, SourceLocation());
+    Diags->setSeverity(diag::warn_arcmt_nsalloc_realloc, diag::Severity::Error,
+                       SourceLocation());
 
   for (unsigned i=0, e = transforms.size(); i != e; ++i)
     transforms[i](pass);
index 9882688289461d746bd2cafaab7225e8fba448a1..686e50496e63f118a580df39038285add6092efd 100644 (file)
@@ -160,9 +160,8 @@ DiagnosticsEngine::GetDiagStatePointForLoc(SourceLocation L) const {
   return Pos;
 }
 
-void DiagnosticsEngine::setDiagnosticMapping(diag::kind Diag,
-                                             diag::Severity Map,
-                                             SourceLocation L) {
+void DiagnosticsEngine::setSeverity(diag::kind Diag, diag::Severity Map,
+                                    SourceLocation L) {
   assert(Diag < diag::DIAG_UPPER_LIMIT &&
          "Can only map builtin diagnostics");
   assert((Diags->isBuiltinWarningOrExtension(Diag) ||
@@ -229,9 +228,8 @@ void DiagnosticsEngine::setDiagnosticMapping(diag::kind Diag,
                                                FullSourceLoc(Loc, *SourceMgr)));
 }
 
-bool DiagnosticsEngine::setDiagnosticGroupMapping(StringRef Group,
-                                                  diag::Severity Map,
-                                                  SourceLocation Loc) {
+bool DiagnosticsEngine::setSeverityForGroup(StringRef Group, diag::Severity Map,
+                                            SourceLocation Loc) {
   // Get the diagnostics in this group.
   SmallVector<diag::kind, 8> GroupDiags;
   if (Diags->getDiagnosticsInGroup(Group, GroupDiags))
@@ -239,7 +237,7 @@ bool DiagnosticsEngine::setDiagnosticGroupMapping(StringRef Group,
 
   // Set the mapping.
   for (unsigned i = 0, e = GroupDiags.size(); i != e; ++i)
-    setDiagnosticMapping(GroupDiags[i], Map, Loc);
+    setSeverity(GroupDiags[i], Map, Loc);
 
   return false;
 }
@@ -249,7 +247,7 @@ bool DiagnosticsEngine::setDiagnosticGroupWarningAsError(StringRef Group,
   // If we are enabling this feature, just set the diagnostic mappings to map to
   // errors.
   if (Enabled)
-    return setDiagnosticGroupMapping(Group, diag::Severity::Error);
+    return setSeverityForGroup(Group, diag::Severity::Error);
 
   // Otherwise, we want to set the diagnostic mapping's "no Werror" bit, and
   // potentially downgrade anything already mapped to be a warning.
@@ -278,7 +276,7 @@ bool DiagnosticsEngine::setDiagnosticGroupErrorAsFatal(StringRef Group,
   // If we are enabling this feature, just set the diagnostic mappings to map to
   // fatal errors.
   if (Enabled)
-    return setDiagnosticGroupMapping(Group, diag::Severity::Fatal);
+    return setSeverityForGroup(Group, diag::Severity::Fatal);
 
   // Otherwise, we want to set the diagnostic mapping's "no Werror" bit, and
   // potentially downgrade anything already mapped to be an error.
@@ -301,8 +299,8 @@ bool DiagnosticsEngine::setDiagnosticGroupErrorAsFatal(StringRef Group,
   return false;
 }
 
-void DiagnosticsEngine::setMappingForAllDiagnostics(diag::Severity Map,
-                                                    SourceLocation Loc) {
+void DiagnosticsEngine::setSeverityForAll(diag::Severity Map,
+                                          SourceLocation Loc) {
   // Get all the diagnostics.
   SmallVector<diag::kind, 64> AllDiags;
   Diags->getAllDiagnostics(AllDiags);
@@ -310,7 +308,7 @@ void DiagnosticsEngine::setMappingForAllDiagnostics(diag::Severity Map,
   // Set the mapping.
   for (unsigned i = 0, e = AllDiags.size(); i != e; ++i)
     if (Diags->isBuiltinWarningOrExtension(AllDiags[i]))
-      setDiagnosticMapping(AllDiags[i], Map, Loc);
+      setSeverity(AllDiags[i], Map, Loc);
 }
 
 void DiagnosticsEngine::Report(const StoredDiagnostic &storedDiag) {
index a0a2164423c16e74a5f5f3747091b332d9e2f637..98f85a053b0d6964c3ad4a298a51a8efbe4cfd4d 100644 (file)
@@ -125,7 +125,7 @@ void clang::ProcessWarningOptions(DiagnosticsEngine &Diags,
             Diags.setEnableAllWarnings(true);
           } else {
             Diags.setEnableAllWarnings(false);
-            Diags.setMappingForAllDiagnostics(diag::Severity::Ignored);
+            Diags.setSeverityForAll(diag::Severity::Ignored);
           }
         }
         continue;
@@ -194,7 +194,7 @@ void clang::ProcessWarningOptions(DiagnosticsEngine &Diags,
           EmitUnknownDiagWarning(Diags, isPositive ? "-W" : "-Wno-", Opt,
                                  isPositive);
       } else {
-        Diags.setDiagnosticGroupMapping(Opt, Mapping);
+        Diags.setSeverityForGroup(Opt, Mapping);
       }
     }
   }
index f1b96f8b55878bd6577550278c1f88d9a1801aca..a5f1a62a708d407653de91d60470bc1604d0d59d 100644 (file)
@@ -998,8 +998,8 @@ public:
       return;
     }
 
-    if (PP.getDiagnostics().setDiagnosticGroupMapping(WarningName.substr(2), SV,
-                                                      DiagLoc))
+    if (PP.getDiagnostics().setSeverityForGroup(WarningName.substr(2), SV,
+                                                DiagLoc))
       PP.Diag(StringLoc, diag::warn_pragma_diagnostic_unknown_warning)
         << WarningName;
     else if (Callbacks)
index 723d4140151caa9dd9ecee232b8c5fc32c0e7a62..08e396a27644e64816973272c8b3eb8b3154dc29 100644 (file)
@@ -1215,9 +1215,8 @@ PragmaNoOpenMPHandler::HandlePragma(Preprocessor &PP,
                                              FirstTok.getLocation()) !=
       DiagnosticsEngine::Ignored) {
     PP.Diag(FirstTok, diag::warn_pragma_omp_ignored);
-    PP.getDiagnostics().setDiagnosticMapping(diag::warn_pragma_omp_ignored,
-                                             diag::Severity::Ignored,
-                                             SourceLocation());
+    PP.getDiagnostics().setSeverity(diag::warn_pragma_omp_ignored,
+                                    diag::Severity::Ignored, SourceLocation());
   }
   PP.DiscardUntilEndOfDirective();
 }