Fix booltestsel() for case where we have NULL stats but not MCV stats.

In a boolean column that contains mostly nulls, ANALYZE might not find
enough non-null values to populate the most-common-values stats,
but it would still create a pg_statistic entry with stanullfrac set.
The logic in booltestsel() for this situation did the wrong thing for
"col IS NOT TRUE" and "col IS NOT FALSE" tests, forgetting that null
values would satisfy these tests (so that the true selectivity would
be close to one, not close to zero).  Per bug #8274.

Fix by Andrew Gierth, some comment-smithing by me.

diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend/utils/adt/selfuncs.c
index 1436ce435f38ed2bbe2e84647bb59b505f765cb0..2d83ac964154130067a4d685dacdcb23d6c382f3 100644 (file)
--- a/src/backend/utils/adt/selfuncs.c
+++ b/src/backend/utils/adt/selfuncs.c
@@ -1517,31 +1517,29 @@ booltestsel(PlannerInfo *root, BoolTestType booltesttype, Node *arg,
                        /*
                         * No most-common-value info available. Still have null fraction
                         * information, so use it for IS [NOT] UNKNOWN. Otherwise adjust
-                        * for null fraction and assume an even split for boolean tests.
+                        * for null fraction and assume a 50-50 split of TRUE and FALSE.
                         */
                        switch (booltesttype)
                        {
                                case IS_UNKNOWN:
-
-                                       /*
-                                        * Use freq_null directly.
-                                        */
+                                       /* select only NULL values */
                                        selec = freq_null;
                                        break;
                                case IS_NOT_UNKNOWN:
-
-                                       /*
-                                        * Select not unknown (not null) values. Calculate from
-                                        * freq_null.
-                                        */
+                                       /* select non-NULL values */
                                        selec = 1.0 - freq_null;
                                        break;
                                case IS_TRUE:
-                               case IS_NOT_TRUE:
                                case IS_FALSE:
-                               case IS_NOT_FALSE:
+                                       /* Assume we select half of the non-NULL values */
                                        selec = (1.0 - freq_null) / 2.0;
                                        break;
+                               case IS_NOT_TRUE:
+                               case IS_NOT_FALSE:
+                                       /* Assume we select NULLs plus half of the non-NULLs */
+                                       /* equiv. to freq_null + (1.0 - freq_null) / 2.0 */
+                                       selec = (freq_null + 1.0) / 2.0;
+                                       break;
                                default:
                                        elog(ERROR, "unrecognized booltesttype: %d",
                                                 (int) booltesttype);