Move ip_set_alloc, ip_set_free and ip_set_get_ipaddr* into core

The functions are too large to be inlined, so move them into the core.
Also, fix the unnecessary initializations in ip_set_get_ipaddr*.
(Patrick McHardy's review)

diff --git a/kernel/include/linux/netfilter/ipset/ip_set.h b/kernel/include/linux/netfilter/ipset/ip_set.h
index 2d47aa6859cb488ce65b42cb6de42374fc0c68a1..b35c5d98db0e8b20440df51a81be5090781fe467 100644 (file)
--- a/kernel/include/linux/netfilter/ipset/ip_set.h
+++ b/kernel/include/linux/netfilter/ipset/ip_set.h
@@ -317,38 +317,12 @@ extern int ip_set_del(ip_set_id_t id, const struct sk_buff *skb,
 extern int ip_set_test(ip_set_id_t id, const struct sk_buff *skb,
                       u8 family, u8 dim, u8 flags);
 
-/* Allocate members */
-static inline void *
-ip_set_alloc(size_t size, gfp_t gfp_mask)
-{
-       void *members = NULL;
-
-       if (size < KMALLOC_MAX_SIZE)
-               members = kzalloc(size, gfp_mask | __GFP_NOWARN);
-
-       if (members) {
-               pr_debug("%p: allocated with kmalloc", members);
-               return members;
-       }
-
-       members = __vmalloc(size, gfp_mask | __GFP_ZERO, PAGE_KERNEL);
-       if (!members)
-               return NULL;
-       pr_debug("%p: allocated with vmalloc", members);
-
-       return members;
-}
-
-static inline void
-ip_set_free(void *members)
-{
-       pr_debug("%p: free with %s", members,
-                is_vmalloc_addr(members) ? "vfree" : "kfree");
-       if (is_vmalloc_addr(members))
-               vfree(members);
-       else
-               kfree(members);
-}
+/* Utility functions */
+extern void * ip_set_alloc(size_t size, gfp_t gfp_mask);
+extern void ip_set_free(void *members);
+extern int ip_set_get_ipaddr4(struct nlattr *attr[], int type, u32 *ipaddr);
+extern int ip_set_get_ipaddr6(struct nlattr *attr[], int type,
+                             union nf_inet_addr *ipaddr);
 
 /* Ignore IPSET_ERR_EXIST errors if asked to do so? */
 static inline bool
@@ -390,51 +364,6 @@ ip_set_get_n16(const struct nlattr *attr)
        return attr->nla_type & NLA_F_NET_BYTEORDER ? value : htons(value);
 }
 
-static const struct nla_policy ipaddr_policy[IPSET_ATTR_IPADDR_MAX + 1] = {
-       [IPSET_ATTR_IPADDR_IPV4]        = { .type = NLA_U32 },
-       [IPSET_ATTR_IPADDR_IPV6]        = { .type = NLA_BINARY,
-                                           .len = sizeof(struct in6_addr) },
-};
-
-static inline int
-ip_set_get_ipaddr4(struct nlattr *attr[], int type, u32 *ipaddr)
-{
-       struct nlattr *tb[IPSET_ATTR_IPADDR_MAX+1] = {};
-
-       if (!attr[type])
-               return -IPSET_ERR_PROTOCOL;
-
-       if (nla_parse(tb, IPSET_ATTR_IPADDR_MAX,
-                     nla_data(attr[type]), nla_len(attr[type]),
-                     ipaddr_policy))
-               return -IPSET_ERR_PROTOCOL;
-       if (!tb[IPSET_ATTR_IPADDR_IPV4])
-               return -IPSET_ERR_IPADDR_IPV4;
-
-       *ipaddr = ip_set_get_n32(tb[IPSET_ATTR_IPADDR_IPV4]);
-       return 0;
-}
-
-static inline int
-ip_set_get_ipaddr6(struct nlattr *attr[], int type, union nf_inet_addr *ipaddr)
-{
-       struct nlattr *tb[IPSET_ATTR_IPADDR_MAX+1] = {};
-
-       if (!attr[type])
-               return -IPSET_ERR_PROTOCOL;
-
-       if (nla_parse(tb, IPSET_ATTR_IPADDR_MAX,
-                     nla_data(attr[type]), nla_len(attr[type]),
-                     ipaddr_policy))
-               return -IPSET_ERR_PROTOCOL;
-       if (!tb[IPSET_ATTR_IPADDR_IPV6])
-               return -IPSET_ERR_IPADDR_IPV6;
-
-       memcpy(ipaddr, nla_data(tb[IPSET_ATTR_IPADDR_IPV6]),
-               sizeof(struct in6_addr));
-       return 0;
-}
-
 #define ipset_nest_start(skb, attr) nla_nest_start(skb, attr | NLA_F_NESTED)
 #define ipset_nest_end(skb, start)  nla_nest_end(skb, start)
 

diff --git a/kernel/ip_set_core.c b/kernel/ip_set_core.c
index e38c43e8445213c90f89e3883fbcb3b12631b534..733d3f3832614e29f0e98da793700ce187fbe562 100644 (file)
--- a/kernel/ip_set_core.c
+++ b/kernel/ip_set_core.c
@@ -174,6 +174,88 @@ unlock:
 }
 EXPORT_SYMBOL_GPL(ip_set_type_unregister);
 
+/* Utility functions */
+void *
+ip_set_alloc(size_t size, gfp_t gfp_mask)
+{
+       void *members = NULL;
+
+       if (size < KMALLOC_MAX_SIZE)
+               members = kzalloc(size, gfp_mask | __GFP_NOWARN);
+
+       if (members) {
+               pr_debug("%p: allocated with kmalloc", members);
+               return members;
+       }
+
+       members = __vmalloc(size, gfp_mask | __GFP_ZERO, PAGE_KERNEL);
+       if (!members)
+               return NULL;
+       pr_debug("%p: allocated with vmalloc", members);
+
+       return members;
+}
+EXPORT_SYMBOL_GPL(ip_set_alloc);
+
+void
+ip_set_free(void *members)
+{
+       pr_debug("%p: free with %s", members,
+                is_vmalloc_addr(members) ? "vfree" : "kfree");
+       if (is_vmalloc_addr(members))
+               vfree(members);
+       else
+               kfree(members);
+}
+EXPORT_SYMBOL_GPL(ip_set_free);
+
+static const struct nla_policy ipaddr_policy[IPSET_ATTR_IPADDR_MAX + 1] = {
+       [IPSET_ATTR_IPADDR_IPV4]        = { .type = NLA_U32 },
+       [IPSET_ATTR_IPADDR_IPV6]        = { .type = NLA_BINARY,
+                                           .len = sizeof(struct in6_addr) },
+};
+
+int
+ip_set_get_ipaddr4(struct nlattr *attr[], int type, u32 *ipaddr)
+{
+       struct nlattr *tb[IPSET_ATTR_IPADDR_MAX+1];
+
+       if (!attr[type])
+               return -IPSET_ERR_PROTOCOL;
+
+       if (nla_parse(tb, IPSET_ATTR_IPADDR_MAX,
+                     nla_data(attr[type]), nla_len(attr[type]),
+                     ipaddr_policy))
+               return -IPSET_ERR_PROTOCOL;
+       if (!tb[IPSET_ATTR_IPADDR_IPV4])
+               return -IPSET_ERR_IPADDR_IPV4;
+
+       *ipaddr = ip_set_get_n32(tb[IPSET_ATTR_IPADDR_IPV4]);
+       return 0;
+}
+EXPORT_SYMBOL_GPL(ip_set_get_ipaddr4);
+
+int
+ip_set_get_ipaddr6(struct nlattr *attr[], int type, union nf_inet_addr *ipaddr)
+{
+       struct nlattr *tb[IPSET_ATTR_IPADDR_MAX+1];
+
+       if (!attr[type])
+               return -IPSET_ERR_PROTOCOL;
+
+       if (nla_parse(tb, IPSET_ATTR_IPADDR_MAX,
+                     nla_data(attr[type]), nla_len(attr[type]),
+                     ipaddr_policy))
+               return -IPSET_ERR_PROTOCOL;
+       if (!tb[IPSET_ATTR_IPADDR_IPV6])
+               return -IPSET_ERR_IPADDR_IPV6;
+
+       memcpy(ipaddr, nla_data(tb[IPSET_ATTR_IPADDR_IPV6]),
+               sizeof(struct in6_addr));
+       return 0;
+}
+EXPORT_SYMBOL_GPL(ip_set_get_ipaddr6);
+
 /*
  * Creating/destroying/renaming/swapping affect the existence and
  * the properties of a set. All of these can be executed from userspace