]> granicus.if.org Git - python/commitdiff
print_exception(): handle correctly PyObject_GetAttrString() failure
authorVictor Stinner <victor.stinner@haypocalc.com>
Thu, 26 May 2011 12:25:13 +0000 (14:25 +0200)
committerVictor Stinner <victor.stinner@haypocalc.com>
Thu, 26 May 2011 12:25:13 +0000 (14:25 +0200)
Bug found by the Clang Static Analyzer.

Python/pythonrun.c

index b55dc5b201669fd9317b1b6877ddb3f27a28db46..232d7befa02f6729d52ec429b08c3e7cb3fc3edc 100644 (file)
@@ -1593,7 +1593,7 @@ print_exception(PyObject *f, PyObject *value)
         moduleName = PyObject_GetAttrString(type, "__module__");
         if (moduleName == NULL || !PyUnicode_Check(moduleName))
         {
-            Py_DECREF(moduleName);
+            Py_XDECREF(moduleName);
             err = PyFile_WriteString("<unknown>", f);
         }
         else {