]> granicus.if.org Git - graphviz/commitdiff
core plugin isXDot: remove string compare micro-optimization
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Tue, 27 Sep 2022 15:19:14 +0000 (08:19 -0700)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Wed, 28 Sep 2022 14:57:12 +0000 (07:57 -0700)
Modern compilers are able to do this transformation themselves if they have
worked out that it will be faster.

plugin/core/gvrender_core_json.c

index 4b7438bb83ee2c2cefa9d1d8206fedab2d00dd93..69c117cba77dc980458a3a65a36cdc29d58950ab 100644 (file)
@@ -332,10 +332,9 @@ static void write_xdots (char * val, GVJ_t * job, state_t* sp)
 
 static int isXDot (char* name)
 {
-  return *name++ == '_' &&
-          (streq(name,"draw_") || streq(name,"ldraw_") ||
-          streq(name,"hdraw_") || streq(name,"tdraw_") ||
-          streq(name,"hldraw_") || streq(name,"tldraw_"));
+  return streq(name, "_draw_") || streq(name, "_ldraw_") ||
+         streq(name, "_hdraw_") || streq(name, "_tdraw_") ||
+         streq(name, "_hldraw_") || streq(name, "_tldraw_");
 }
 
 static void write_attrs(Agobj_t * obj, GVJ_t * job, state_t* sp)