]> granicus.if.org Git - llvm/commitdiff
[Support] Remove unnecessary MemoryBuffer::anchor (where the destructor serves as...
authorFangrui Song <maskray@google.com>
Fri, 27 Jul 2018 23:12:11 +0000 (23:12 +0000)
committerFangrui Song <maskray@google.com>
Fri, 27 Jul 2018 23:12:11 +0000 (23:12 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@338175 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/Support/MemoryBuffer.h
include/llvm/Support/SmallVectorMemoryBuffer.h
lib/Support/MemoryBuffer.cpp

index 535579ecff5341109c43aa50e6d3981898c91dc2..8933295d4ea4eeebc2c1bd74d1b1c328884f20a9 100644 (file)
@@ -43,7 +43,6 @@ class MemoryBuffer {
   const char *BufferStart; // Start of the buffer.
   const char *BufferEnd;   // End of the buffer.
 
-
 protected:
   MemoryBuffer() = default;
 
@@ -148,9 +147,6 @@ public:
   virtual BufferKind getBufferKind() const = 0;
 
   MemoryBufferRef getMemBufferRef() const;
-
-private:
-  virtual void anchor();
 };
 
 /// This class is an extension of MemoryBuffer, which allows copy-on-write
index f43c2fb8f826971d8a7ecf58ad33cdb697acb06c..c4a600e7f37ddea9e95efc788adcaee5eb3aebd5 100644 (file)
@@ -49,6 +49,9 @@ public:
     init(this->SV.begin(), this->SV.end(), false);
   }
 
+  // Key function.
+  ~SmallVectorMemoryBuffer() override;
+
   StringRef getBufferIdentifier() const override { return BufferName; }
 
   BufferKind getBufferKind() const override { return MemoryBuffer_Malloc; }
@@ -56,7 +59,6 @@ public:
 private:
   SmallVector<char, 0> SV;
   std::string BufferName;
-  void anchor() override;
 };
 
 } // namespace llvm
index 4428c2f24e3214e5817ec68508d7c4fde2d363f6..e9505490e9c5a03130742bf9b162d00c48ecb356 100644 (file)
@@ -533,5 +533,4 @@ MemoryBufferRef MemoryBuffer::getMemBufferRef() const {
   return MemoryBufferRef(Data, Identifier);
 }
 
-void MemoryBuffer::anchor() {}
-void SmallVectorMemoryBuffer::anchor() {}
+SmallVectorMemoryBuffer::~SmallVectorMemoryBuffer() {}