Patch #1449244: Support Unicode strings in

email.message.Message.{set_charset,get_content_charset}.

diff --git a/Lib/email/message.py b/Lib/email/message.py
index 79c5c4c6f3fd875494775ba1571021bb32367a72..88ae1833e3b75472a8340cadb76e6cc93440edb4 100644 (file)
--- a/Lib/email/message.py
+++ b/Lib/email/message.py
@@ -238,7 +238,7 @@ class Message:
             self.del_param('charset')
             self._charset = None
             return
-        if isinstance(charset, str):
+        if isinstance(charset, basestring):
             charset = email.charset.Charset(charset)
         if not isinstance(charset, email.charset.Charset):
             raise TypeError(charset)
@@ -756,7 +756,9 @@ class Message:
                 charset = charset[2]
         # charset character must be in us-ascii range
         try:
-            charset = unicode(charset, 'us-ascii').encode('us-ascii')
+            if isinstance(charset, str):
+                charset = unicode(charset, 'us-ascii')
+            charset = charset.encode('us-ascii')
         except UnicodeError:
             return failobj
         # RFC 2046, $4.1.2 says charsets are not case sensitive

diff --git a/Lib/email/test/test_email.py b/Lib/email/test/test_email.py
index eb2a73c6e3a8cf1477d1a7d9e8448bd97f46e172..14b8a1b8dc23fc342bb590f59d5023537e65733c 100644 (file)
--- a/Lib/email/test/test_email.py
+++ b/Lib/email/test/test_email.py
@@ -502,6 +502,13 @@ class TestMessageAPI(TestEmailBase):
         msg.set_payload(x)
         self.assertEqual(msg.get_payload(decode=True), x)
 
+    def test_get_content_charset(self):
+        msg = Message()
+        msg.set_charset('us-ascii')
+        self.assertEqual('us-ascii', msg.get_content_charset())
+        msg.set_charset(u'us-ascii')
+        self.assertEqual('us-ascii', msg.get_content_charset())
+
 
 \f
 # Test the email.Encoders module

diff --git a/Misc/NEWS b/Misc/NEWS
index 3a5edc0a8b077c88cec61bf67125a83d45a406dc..5e44c2592959fb0c1f6655796a0b6711dae17696 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -202,6 +202,9 @@ Extension Modules
 Library
 -------
 
+- Patch #1449244: Support Unicode strings in
+  email.message.Message.{set_charset,get_content_charset}.
+
 - Patch #1542681: add entries for "with", "as" and "CONTEXTMANAGERS" to
   pydoc's help keywords.