Change relblocknumber field of pg_buffercache view from numeric to int8

for efficiency's sake.  Mark Kirkwood.

diff --git a/contrib/pg_buffercache/README.pg_buffercache b/contrib/pg_buffercache/README.pg_buffercache
index 59ec142a29c5a60fdc9cc7f9162f179f3ea03071..b5c9321553293ae79b8be1835d1025e81fbae69c 100644 (file)
--- a/contrib/pg_buffercache/README.pg_buffercache
+++ b/contrib/pg_buffercache/README.pg_buffercache
@@ -34,7 +34,7 @@ Notes
 
        Column     |  references          | Description
   ----------------+----------------------+------------------------------------
-   bufferid       |                      | Id, 1->shared_buffers.
+   bufferid       |                      | Id, 1..shared_buffers.
    relfilenode    | pg_class.relfilenode | Refilenode of the relation.
    reltablespace  | pg_tablespace.oid    | Tablespace oid of the relation.
    reldatabase    | pg_database.oid      | Database for the relation.
@@ -66,13 +66,13 @@ Sample output
    relfilenode    | oid     |
    reltablespace  | oid     |
    reldatabase    | oid     |
-   relblocknumber | numeric |
+   relblocknumber | bigint  |
    isdirty        | boolean |
   View definition:
    SELECT p.bufferid, p.relfilenode, p.reltablespace, p.reldatabase, 
           p.relblocknumber, p.isdirty
      FROM pg_buffercache_pages() p(bufferid integer, relfilenode oid, 
-     reltablespace oid, reldatabase oid, relblocknumber numeric(10,0), 
+     reltablespace oid, reldatabase oid, relblocknumber bigint, 
      isdirty boolean);
 
   regression=# SELECT c.relname, count(*) AS buffers

diff --git a/contrib/pg_buffercache/pg_buffercache.sql.in b/contrib/pg_buffercache/pg_buffercache.sql.in
index 7dea72556be06056b3322a0893fa87dca4a74b79..1dd0b2eae6cbc262ca37e6305db506f9f89cee00 100644 (file)
--- a/contrib/pg_buffercache/pg_buffercache.sql.in
+++ b/contrib/pg_buffercache/pg_buffercache.sql.in
@@ -11,7 +11,7 @@ LANGUAGE 'C';
 CREATE VIEW pg_buffercache AS
        SELECT P.* FROM pg_buffercache_pages() AS P
        (bufferid integer, relfilenode oid, reltablespace oid, reldatabase oid, 
-        relblocknumber numeric(10), isdirty bool);
+        relblocknumber int8, isdirty bool);
  
 -- Don't want these to be available at public.
 REVOKE ALL ON FUNCTION pg_buffercache_pages() FROM PUBLIC;

diff --git a/contrib/pg_buffercache/pg_buffercache_pages.c b/contrib/pg_buffercache/pg_buffercache_pages.c
index 58a68f5962225862da40642d3047b7ed80913347..e55aff991dc8e7ae2af29234fb26adb62fe98d47 100644 (file)
--- a/contrib/pg_buffercache/pg_buffercache_pages.c
+++ b/contrib/pg_buffercache/pg_buffercache_pages.c
@@ -3,7 +3,7 @@
  * pg_buffercache_pages.c
  *    display some contents of the buffer cache
  *
- *       $PostgreSQL: pgsql/contrib/pg_buffercache/pg_buffercache_pages.c,v 1.3 2005/04/01 08:41:19 neilc Exp $
+ *       $PostgreSQL: pgsql/contrib/pg_buffercache/pg_buffercache_pages.c,v 1.4 2005/05/31 00:07:47 tgl Exp $
  *-------------------------------------------------------------------------
  */
 #include "postgres.h"
@@ -92,8 +92,8 @@ pg_buffercache_pages(PG_FUNCTION_ARGS)
                                                                        OIDOID, -1, 0);
                TupleDescInitEntry(tupledesc, (AttrNumber) 4, "reldatabase",
                                                                        OIDOID, -1, 0);
-               TupleDescInitEntry(tupledesc, (AttrNumber) 5, "relblockbumber",
-                                                                       NUMERICOID, -1, 0);
+               TupleDescInitEntry(tupledesc, (AttrNumber) 5, "relblocknumber",
+                                                                       INT8OID, -1, 0);
                TupleDescInitEntry(tupledesc, (AttrNumber) 6, "isdirty",
                                                                        BOOLOID, -1, 0);