bpo-33901: Fix test_dbm_gnu for gdbm 1.15 (GH-7791)
authorVictor Stinner <vstinner@redhat.com>
Tue, 19 Jun 2018 12:19:54 +0000 (14:19 +0200)
committerGitHub <noreply@github.com>
Tue, 19 Jun 2018 12:19:54 +0000 (14:19 +0200)
Using gdbm 1.15, creating a database creates a file of 16 MiB. Adding
a small entry and then modifying the small entry doesn't change the
file size. Modify test_dbm_gnu to be less strict: allow that the file
size doesn't change.

Lib/test/test_dbm_gnu.py
Misc/NEWS.d/next/Tests/2018-06-19-14-04-21.bpo-33901.OFW1Sr.rst [new file with mode: 0644]

index 50b8a192e55ca6cf2752cc2cea56db6b1bd6de7d..8d76fc75a8ce44a9d9e34bc87cc691325eb3bb74 100644 (file)
@@ -74,7 +74,7 @@ class TestGdbm(unittest.TestCase):
 
         self.g['x'] = 'x' * 10000
         size1 = os.path.getsize(filename)
-        self.assertGreater(size1, size0)
+        self.assertGreaterEqual(size1, size0)
 
         del self.g['x']
         # 'size' is supposed to be the same even after deleting an entry.
@@ -82,7 +82,7 @@ class TestGdbm(unittest.TestCase):
 
         self.g.reorganize()
         size2 = os.path.getsize(filename)
-        self.assertLess(size2, size1)
+        self.assertLessEqual(size2, size1)
         self.assertGreaterEqual(size2, size0)
 
     def test_context_manager(self):
diff --git a/Misc/NEWS.d/next/Tests/2018-06-19-14-04-21.bpo-33901.OFW1Sr.rst b/Misc/NEWS.d/next/Tests/2018-06-19-14-04-21.bpo-33901.OFW1Sr.rst
new file mode 100644 (file)
index 0000000..0ca9b60
--- /dev/null
@@ -0,0 +1,4 @@
+Fix test_dbm_gnu for gdbm 1.15. Using gdbm 1.15, creating a database creates
+a file of 16 MiB. Adding a small entry and then modifying the small entry
+doesn't change the file size. Modify test_dbm_gnu to be less strict: allow
+that the file size doesn't change.