Issue #8629: Disable some test_ssl tests, since they give different

results with OpenSSL 1.0.0 and higher.

diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py
index db640c135ac176696ff2dc6e89ed3f3b611ceb76..6d49994bb53e521dd005912710e44ee2b64b973a 100644 (file)
--- a/Lib/test/test_ssl.py
+++ b/Lib/test/test_ssl.py
@@ -716,7 +716,7 @@ else:
                 raise
         else:
             if not expect_success:
-                self.fail(
+                raise AssertionError(
                     "Client protocol %s succeeded with server protocol %s!"
                     % (ssl.get_protocol_name(client_protocol),
                        ssl.get_protocol_name(server_protocol)))
@@ -832,7 +832,9 @@ else:
         def test_protocol_sslv2(self):
             """Connecting to an SSLv2 server with various client options"""
             if test_support.verbose:
-                sys.stdout.write("\n")
+                sys.stdout.write("\ntest_protocol_sslv2 disabled, "
+                                 "as it fails on OpenSSL 1.0.0+")
+            return
             try_protocol_combo(ssl.PROTOCOL_SSLv2, ssl.PROTOCOL_SSLv2, True)
             try_protocol_combo(ssl.PROTOCOL_SSLv2, ssl.PROTOCOL_SSLv2, True, ssl.CERT_OPTIONAL)
             try_protocol_combo(ssl.PROTOCOL_SSLv2, ssl.PROTOCOL_SSLv2, True, ssl.CERT_REQUIRED)
@@ -843,7 +845,9 @@ else:
         def test_protocol_sslv23(self):
             """Connecting to an SSLv23 server with various client options"""
             if test_support.verbose:
-                sys.stdout.write("\n")
+                sys.stdout.write("\ntest_protocol_sslv23 disabled, "
+                                 "as it fails on OpenSSL 1.0.0+")
+            return
             try:
                 try_protocol_combo(ssl.PROTOCOL_SSLv23, ssl.PROTOCOL_SSLv2, True)
             except (ssl.SSLError, socket.error), x:
@@ -867,7 +871,9 @@ else:
         def test_protocol_sslv3(self):
             """Connecting to an SSLv3 server with various client options"""
             if test_support.verbose:
-                sys.stdout.write("\n")
+                sys.stdout.write("\ntest_protocol_sslv3 disabled, "
+                                 "as it fails on OpenSSL 1.0.0+")
+            return
             try_protocol_combo(ssl.PROTOCOL_SSLv3, ssl.PROTOCOL_SSLv3, True)
             try_protocol_combo(ssl.PROTOCOL_SSLv3, ssl.PROTOCOL_SSLv3, True, ssl.CERT_OPTIONAL)
             try_protocol_combo(ssl.PROTOCOL_SSLv3, ssl.PROTOCOL_SSLv3, True, ssl.CERT_REQUIRED)
@@ -878,7 +884,9 @@ else:
         def test_protocol_tlsv1(self):
             """Connecting to a TLSv1 server with various client options"""
             if test_support.verbose:
-                sys.stdout.write("\n")
+                sys.stdout.write("\ntest_protocol_tlsv1 disabled, "
+                                 "as it fails on OpenSSL 1.0.0+")
+            return
             try_protocol_combo(ssl.PROTOCOL_TLSv1, ssl.PROTOCOL_TLSv1, True)
             try_protocol_combo(ssl.PROTOCOL_TLSv1, ssl.PROTOCOL_TLSv1, True, ssl.CERT_OPTIONAL)
             try_protocol_combo(ssl.PROTOCOL_TLSv1, ssl.PROTOCOL_TLSv1, True, ssl.CERT_REQUIRED)

diff --git a/Misc/NEWS b/Misc/NEWS
index 85e40d880896db015544beb5bc0c120679792c81..7bafbbe5b42a3e89ab4718be0353e0d9ca9ab4f0 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -164,6 +164,9 @@ Build
 Tests
 -----
 
+- Issue #8629: Disable some test_ssl tests, since they give different
+  results with OpenSSL 1.0.0 and higher.
+
 - Issue #8576: Remove use of find_unused_port() in test_smtplib and
   test_multiprocessing.  Patch by Paul Moore.