]> granicus.if.org Git - curl/commitdiff
progress: let "current speed" be UL + DL speeds combined
authorDaniel Stenberg <daniel@haxx.se>
Fri, 9 Jun 2017 09:16:18 +0000 (11:16 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Wed, 14 Jun 2017 21:30:54 +0000 (23:30 +0200)
Bug #1556
Reported-by: Paul Harris
Closes #1559

lib/progress.c

index 1996d78dccd20c2e304d488146d6430da3c6702d..ccabe3c5d68d66f97199b218172346b2c5da2e9c 100644 (file)
@@ -380,11 +380,10 @@ int Curl_pgrsUpdate(struct connectdata *conn)
 
     data->progress.lastshow = now.tv_sec;
 
-    /* Let's do the "current speed" thing, which should use the fastest
-       of the dl/ul speeds. Store the faster speed at entry 'nowindex'. */
+    /* Let's do the "current speed" thing, with the dl + ul speeds
+       combined. Store the speed at entry 'nowindex'. */
     data->progress.speeder[ nowindex ] =
-      data->progress.downloaded>data->progress.uploaded?
-      data->progress.downloaded:data->progress.uploaded;
+      data->progress.downloaded + data->progress.uploaded;
 
     /* remember the exact time for this moment */
     data->progress.speeder_time [ nowindex ] = now;
@@ -433,10 +432,9 @@ int Curl_pgrsUpdate(struct connectdata *conn)
       }
     }
     else
-      /* the first second we use the main average */
+      /* the first second we use the average */
       data->progress.current_speed =
-        (data->progress.ulspeed>data->progress.dlspeed)?
-        data->progress.ulspeed:data->progress.dlspeed;
+        data->progress.ulspeed + data->progress.dlspeed;
 
   } /* Calculations end */