Created test cases 1080 and 1081 to reproduce a problem of

CURLINFO_REDIRECT_URL leaking memory and returning incorrect results when
two URLs are requested. Reported by vmpdemo in bug #2152270

diff --git a/CHANGES b/CHANGES
index 2aeba086c4c2dac109f57bd9a32525c73d320202..798c97c6e31569cda97e059b679efb785403fb8b 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -13,6 +13,10 @@ Daniel Fandrich (7 Oct 2008)
   test a similar connection dropping scenario, but as a race condition, it's
   hard to test reliably.
 
+- Created test cases 1080 and 1081 to reproduce a problem of
+  CURLINFO_REDIRECT_URL leaking memory and returning incorrect results when
+  two URLs are requested. Reported by vmpdemo in bug #2152270
+
 Daniel Stenberg (7 Oct 2008)
 - Fixed CURLINFO_PRIMARY_IP: When libcurl created a connection to host A then
   the app re-used the handle to do a connection to host B and then again

diff --git a/tests/data/DISABLED b/tests/data/DISABLED
index 2055e9f1670f2b6663fddf8530ef06aed5cce807..f917042afaa0959dc9d3d8bedc351b5a54a36003 100644 (file)
--- a/tests/data/DISABLED
+++ b/tests/data/DISABLED
@@ -3,3 +3,5 @@
 # test cases are run by runtests.pl. Just add the plain test case numbers, one
 # per line.
 # Lines starting with '#' letters are treated as comments.
+1080
+1081

diff --git a/tests/data/Makefile.am b/tests/data/Makefile.am
index dd3c537fb207e2536987655ded2a240be94faf88..a7b4fc1fb5937ed7f4fd0afc6b22d4b3bc6c1e9d 100644 (file)
--- a/tests/data/Makefile.am
+++ b/tests/data/Makefile.am
@@ -57,7 +57,8 @@ EXTRA_DIST = test1 test108 test117 test127 test20 test27 test34 test46           \
  test1048 test1049 test1050 test1051 test1052 test1053 test1054 test1055   \
  test1056 test1057 test1058 test1059 test1060 test1061 test1062 test1063   \
  test1064 test1065 test1066 test1067 test1068 test1069 test1070 test1071   \
- test1072 test1073 test1074 test1075 test1076 test1077 test1078 test1079
+ test1072 test1073 test1074 test1075 test1076 test1077 test1078 test1079   \
+ test1080 test1081
 
 filecheck:
        @mkdir test-place; \

diff --git a/tests/data/test1080 b/tests/data/test1080
new file mode 100644 (file)
index 0000000..5879a6f
--- /dev/null
+++ b/tests/data/test1080
@@ -0,0 +1,69 @@
+<testcase>
+<info>
+<keywords>
+HTTP
+HTTP GET
+redirect_url
+followlocation
+--write-out
+</keywords>
+</info>
+
+# Server-side
+<reply>
+<data nocheck="1">
+HTTP/1.1 301 This is a weirdo text message swsclose\r
+Location: data/10800002.txt?coolsite=yes\r
+Content-Length: 62\r
+Connection: close\r
+\r
+This server reply is for testing a simple Location: following
+</data>
+</reply>
+
+# Client-side
+<client>
+<server>
+http
+</server>
+ <name>
+HTTP Location: on two URLs 'redirect_url' check
+ </name>
+ <command>
+http://%HOSTIP:%HTTPPORT/we/want/our/1080 http://%HOSTIP:%HTTPPORT/we/want/our/1080 -w '%{redirect_url}\n'
+</command>
+</client>
+
+# Verify data after the test has been "shot"
+<verify>
+<strip>
+^User-Agent:.*
+</strip>
+<protocol>
+GET /we/want/our/1080 HTTP/1.1\r
+Host: %HOSTIP:%HTTPPORT\r
+Accept: */*\r
+\r
+GET /we/want/our/1080 HTTP/1.1\r
+Host: %HOSTIP:%HTTPPORT\r
+Accept: */*\r
+\r
+</protocol>
+<stdout mode="text">
+HTTP/1.1 301 This is a weirdo text message swsclose\r
+Location: data/10800002.txt?coolsite=yes\r
+Content-Length: 62\r
+Connection: close\r
+\r
+This server reply is for testing a simple Location: following
+http://%HOSTIP:%HTTPPORT/we/want/our/data/10800002.txt?coolsite=yes
+HTTP/1.1 301 This is a weirdo text message swsclose\r
+Location: data/10800002.txt?coolsite=yes\r
+Content-Length: 62\r
+Connection: close\r
+\r
+This server reply is for testing a simple Location: following
+http://%HOSTIP:%HTTPPORT/we/want/our/data/10800002.txt?coolsite=yes
+</stdout>
+</verify>
+</testcase>

diff --git a/tests/data/test1081 b/tests/data/test1081
new file mode 100644 (file)
index 0000000..b91ef60
--- /dev/null
+++ b/tests/data/test1081
@@ -0,0 +1,77 @@
+<testcase>
+<info>
+<keywords>
+HTTP
+HTTP GET
+redirect_url
+followlocation
+--write-out
+</keywords>
+</info>
+
+# Server-side
+<reply>
+<data nocheck="1">
+HTTP/1.1 301 This is a weirdo text message swsclose\r
+Location: data/10810099.txt?coolsite=yes\r
+Content-Length: 62\r
+Connection: close\r
+\r
+This server reply is for testing a simple Location: following
+</data>
+<data2 nocheck="1">
+HTTP/1.1 200 Followed here fine swsclose\r
+Date: Thu, 09 Nov 2010 14:49:00 GMT\r
+Server: test-server/fake\r
+Content-Length: 41\r
+\r
+This second URL does not have a location
+</data2>
+</reply>
+
+# Client-side
+<client>
+<server>
+http
+</server>
+ <name>
+HTTP no Location: on second URL 'redirect_url' check
+ </name>
+ <command>
+http://%HOSTIP:%HTTPPORT/we/want/our/1081 http://%HOSTIP:%HTTPPORT/we/want/our/10810002 -w '%{redirect_url}\n'
+</command>
+</client>
+
+# Verify data after the test has been "shot"
+<verify>
+<strip>
+^User-Agent:.*
+</strip>
+<protocol>
+GET /we/want/our/1081 HTTP/1.1\r
+Host: %HOSTIP:%HTTPPORT\r
+Accept: */*\r
+\r
+GET /we/want/our/10810002 HTTP/1.1\r
+Host: %HOSTIP:%HTTPPORT\r
+Accept: */*\r
+\r
+</protocol>
+<stdout mode="text">
+HTTP/1.1 301 This is a weirdo text message swsclose\r
+Location: data/10810099.txt?coolsite=yes\r
+Content-Length: 62\r
+Connection: close\r
+\r
+This server reply is for testing a simple Location: following
+http://%HOSTIP:%HTTPPORT/we/want/our/data/10810099.txt?coolsite=yes
+HTTP/1.1 200 Followed here fine swsclose\r
+Date: Thu, 09 Nov 2010 14:49:00 GMT\r
+Server: test-server/fake\r
+Content-Length: 41\r
+\r
+This second URL does not have a location
+
+</stdout>
+</verify>
+</testcase>