components/bt: Remove warnings in btc_gatts_arg_deep_copy() that are confusing

Fixes: https://github.com/espressif/esp-idf/issues/2811
The warning print "NULL value" is only kept for event
BTC_GATTS_ACT_SET_ATTR_VALUE as this can be useful in case user forgets
to set attribute value

Signed-off-by: Hrishikesh Dhayagude <hrishi@espressif.com>

diff --git a/components/bt/bluedroid/bta/gatt/bta_gatts_act.c b/components/bt/bluedroid/bta/gatt/bta_gatts_act.c
index 283e923e1906947fa26f6d5325ca1f2e9bc83e22..58f76eb77a500b2bf3b418d545d66d5496ad2258 100644 (file)
--- a/components/bt/bluedroid/bta/gatt/bta_gatts_act.c
+++ b/components/bt/bluedroid/bta/gatt/bta_gatts_act.c
@@ -707,8 +707,6 @@ void bta_gatts_indicate_handle (tBTA_GATTS_CB *p_cb, tBTA_GATTS_DATA *p_msg)
             } else {
                 if (p_msg->api_indicate.value) {
                     APPL_TRACE_ERROR("%s, incorrect length", __func__);
-                } else {
-                    APPL_TRACE_WARNING("%s, NULL value", __func__);
                 }
             }
             (*p_rcb->p_cback)(BTA_GATTS_CONF_EVT, &cb_data);

diff --git a/components/bt/bluedroid/btc/profile/std/gatt/btc_gatts.c b/components/bt/bluedroid/btc/profile/std/gatt/btc_gatts.c
index 110935f8f385cab91613ea7aa8af28990f25407e..fb5ec963a01feaa71a78f51a6fc91de6658d9b3c 100644 (file)
--- a/components/bt/bluedroid/btc/profile/std/gatt/btc_gatts.c
+++ b/components/bt/bluedroid/btc/profile/std/gatt/btc_gatts.c
@@ -92,8 +92,6 @@ void btc_gatts_arg_deep_copy(btc_msg_t *msg, void *p_dest, void *p_src)
             dst->send_ind.value = NULL;
             if (src->send_ind.value) {
                 BTC_TRACE_ERROR("%s %d, invalid length", __func__, msg->act);
-            } else {
-                BTC_TRACE_WARNING("%s %d, NULL value", __func__, msg->act);
             }
         }
         break;
@@ -106,8 +104,6 @@ void btc_gatts_arg_deep_copy(btc_msg_t *msg, void *p_dest, void *p_src)
             } else {
                 BTC_TRACE_ERROR("%s %d no mem\n", __func__, msg->act);
             }
-        } else {
-            BTC_TRACE_WARNING("%s %d, NULL response", __func__, msg->act);
         }
         break;
     
@@ -125,8 +121,6 @@ void btc_gatts_arg_deep_copy(btc_msg_t *msg, void *p_dest, void *p_src)
             dst->add_char.char_val.attr_value = NULL;
             if (src->add_char.char_val.attr_value) {
                 BTC_TRACE_ERROR("%s %d, invalid length", __func__, msg->act);
-            } else {
-                BTC_TRACE_WARNING("%s %d, NULL value", __func__, msg->act);
             }
         }
         break;
@@ -144,8 +138,6 @@ void btc_gatts_arg_deep_copy(btc_msg_t *msg, void *p_dest, void *p_src)
             dst->add_descr.descr_val.attr_value = NULL;
             if (src->add_descr.descr_val.attr_value) {
                 BTC_TRACE_ERROR("%s %d, invalid length", __func__, msg->act);
-            } else {
-                BTC_TRACE_WARNING("%s %d, NULL value", __func__, msg->act);
             }
         }
         break;