]> granicus.if.org Git - llvm/commitdiff
[lit] Throw in unimplemented method (NFC)
authorChris Bieneman <beanz@apple.com>
Mon, 3 Oct 2016 04:48:22 +0000 (04:48 +0000)
committerChris Bieneman <beanz@apple.com>
Mon, 3 Oct 2016 04:48:22 +0000 (04:48 +0000)
Summary:
lit's `OneCommandFileTest` class implements an abstract method that
raises if called. However, it raises by referencing an undefined
symbol. Instead, raise explicitly by throwing a `NotImplementedError`.
This is clearer, and appeases Python linters.

Patch By Brian Gesiak!

Reviewers: ddunbar, echristo, beanz

Subscribers: llvm-commits, mehdi_amini

Differential Revision: https://reviews.llvm.org/D25170

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@283090 91177308-0d34-0410-b5e6-96231b3b80d8

utils/lit/lit/formats/base.py

index 3d305cca5fc0b296e7db9a0cc9acec9091b1a731..6721d17e334e6756c6dba4b47a9d41adff6fc6e4 100644 (file)
@@ -80,7 +80,7 @@ class OneCommandPerFileTest(TestFormat):
                 yield test
 
     def createTempInput(self, tmp, test):
-        abstract
+        raise NotImplementedError('This is an abstract method.')
 
     def execute(self, test, litConfig):
         if test.config.unsupported: