]> granicus.if.org Git - php/commitdiff
Fix segfault with scalar passed to typehint with not loaded class
authorBob Weinand <bobwei9@hotmail.com>
Sat, 20 Jun 2015 23:35:22 +0000 (01:35 +0200)
committerBob Weinand <bobwei9@hotmail.com>
Sat, 20 Jun 2015 23:35:22 +0000 (01:35 +0200)
Zend/tests/typehints/inexistent_class_hint_with_scalar_arg.phpt [new file with mode: 0644]
Zend/zend_execute.c

diff --git a/Zend/tests/typehints/inexistent_class_hint_with_scalar_arg.phpt b/Zend/tests/typehints/inexistent_class_hint_with_scalar_arg.phpt
new file mode 100644 (file)
index 0000000..3bacf82
--- /dev/null
@@ -0,0 +1,16 @@
+--TEST--
+Inexistent class as typehint receiving scalar argument
+--FILE--
+<?php
+
+function foo(bar $ex) {}
+foo(null);
+
+?>
+--EXPECTF--
+Fatal error: Uncaught TypeError: Argument 1 passed to foo() must be an instance of bar, null given, called in %s on line %d and defined in %s:%d
+Stack trace:
+#0 %s(%d): foo(NULL)
+#1 {main}
+  thrown in %s on line %d
+
index 491dbb8e68f1880dc01ed8dab4d6dd873b55b0fa..246372fee2dae569ac6075f3f9cd808336470fd6 100644 (file)
@@ -780,7 +780,11 @@ static zend_always_inline int zend_verify_arg_type(zend_function *zf, uint32_t a
                                } else {
                                        ce = zend_verify_arg_class_kind(cur_arg_info);
                                        if (UNEXPECTED(!ce)) {
-                                               zend_verify_arg_error(zf, arg_num, "be an instance of ", cur_arg_info->class_name->val, "instance of ", Z_OBJCE_P(arg)->name->val, arg);
+                                               if (Z_TYPE_P(arg) == IS_OBJECT) {
+                                                       zend_verify_arg_error(zf, arg_num, "be an instance of ", cur_arg_info->class_name->val, "instance of ", Z_OBJCE_P(arg)->name->val, arg);
+                                               } else {
+                                                       zend_verify_arg_error(zf, arg_num, "be an instance of ", cur_arg_info->class_name->val, "", zend_zval_type_name(arg), arg);
+                                               }
                                                return 0;
                                        }
                                        *cache_slot = (void*)ce;