]> granicus.if.org Git - python/commitdiff
#19662: Eliminate warnings in other test modules that use smtpd.
authorR David Murray <rdmurray@bitdance.com>
Wed, 11 Jun 2014 16:27:40 +0000 (12:27 -0400)
committerR David Murray <rdmurray@bitdance.com>
Wed, 11 Jun 2014 16:27:40 +0000 (12:27 -0400)
Eventually these will want to convert to decode_data=False, I think.

Lib/test/test_logging.py
Lib/test/test_smtplib.py

index f765c3747c188fb3f9565143b9960125ffb57304..52412d1217862c759a022130e321e0d87f0c4975 100644 (file)
@@ -679,7 +679,8 @@ if threading:
         """
 
         def __init__(self, addr, handler, poll_interval, sockmap):
-            smtpd.SMTPServer.__init__(self, addr, None, map=sockmap)
+            smtpd.SMTPServer.__init__(self, addr, None, map=sockmap,
+                                      decode_data=True)
             self.port = self.socket.getsockname()[1]
             self._handler = handler
             self._thread = None
index 16e90f4ab321ec6afcfaf8ff215d7cf46b0471c8..5bff25bafd5be7de90f7bf7e610b46d3f7d767be 100644 (file)
@@ -184,7 +184,8 @@ class DebuggingServerTests(unittest.TestCase):
         self.old_DEBUGSTREAM = smtpd.DEBUGSTREAM
         smtpd.DEBUGSTREAM = io.StringIO()
         # Pick a random unused port by passing 0 for the port number
-        self.serv = smtpd.DebuggingServer((HOST, 0), ('nowhere', -1))
+        self.serv = smtpd.DebuggingServer((HOST, 0), ('nowhere', -1),
+                                          decode_data=True)
         # Keep a note of what port was assigned
         self.port = self.serv.socket.getsockname()[1]
         serv_args = (self.serv, self.serv_evt, self.client_evt)
@@ -719,7 +720,8 @@ class SimSMTPServer(smtpd.SMTPServer):
 
     def handle_accepted(self, conn, addr):
         self._SMTPchannel = self.channel_class(
-            self._extra_features, self, conn, addr)
+            self._extra_features, self, conn, addr,
+            decode_data=self._decode_data)
 
     def process_message(self, peer, mailfrom, rcpttos, data):
         pass
@@ -742,7 +744,7 @@ class SMTPSimTests(unittest.TestCase):
         self.serv_evt = threading.Event()
         self.client_evt = threading.Event()
         # Pick a random unused port by passing 0 for the port number
-        self.serv = SimSMTPServer((HOST, 0), ('nowhere', -1))
+        self.serv = SimSMTPServer((HOST, 0), ('nowhere', -1), decode_data=True)
         # Keep a note of what port was assigned
         self.port = self.serv.socket.getsockname()[1]
         serv_args = (self.serv, self.serv_evt, self.client_evt)