open_the_file(): this routine has a borrowed reference to the file

object, so the "Metroworks only" section should not decref it in case
of error (the caller is responsible for decref'ing in case of error --
and does).

diff --git a/Objects/fileobject.c b/Objects/fileobject.c
index 9284185be637cb306d1ddafcddc30480dc3236f6..b4f9e9b5c68e27e02f7ed7e135141fd3626db4a3 100644 (file)
--- a/Objects/fileobject.c
+++ b/Objects/fileobject.c
@@ -123,7 +123,6 @@ open_the_file(PyFileObject *f, char *name, char *mode)
                /* Metroworks only, not testable, so unchanged */
                if (errno == 0) {
                        PyErr_SetString(PyExc_IOError, "Cannot open file");
-                       Py_DECREF(f);
                        return NULL;
                }
 #endif